Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: fix a bug that upgrading from 3.1.1 to 4.0 fails #17293

Merged
merged 3 commits into from
May 19, 2020

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented May 19, 2020

What problem does this PR solve?

Issue Number: close #17292

Problem Summary:
The server version 39 in v3.1.1 is not consistent with v4.0+

What is changed and how it works?

Add a new server version 46, and redo version 39.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    git checkout v3.1.1
    make && run
    exit
    git checkout this_pr
    make && run
    success

Side effects

Release note

  • fix a bug that upgrading from 3.1.1 to 4.0 fails

@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #17293 into master will increase coverage by 0.0731%.
The diff coverage is 71.4285%.

@@               Coverage Diff                @@
##             master     #17293        +/-   ##
================================================
+ Coverage   79.9037%   79.9768%   +0.0731%     
================================================
  Files           520        511         -9     
  Lines        140210     139189      -1021     
================================================
- Hits         112033     111319       -714     
+ Misses        19209      18904       -305     
+ Partials       8968       8966         -2     

Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu requested a review from imtbkcat May 19, 2020 13:06
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. labels May 19, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 19, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented May 19, 2020

cherry pick to release-4.0 in PR #17300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade from 3.1.1 to 4.0.0 rc2 fails
4 participants