Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gc_worker: disable green GC by default #17089

Merged
merged 2 commits into from
May 11, 2020

Conversation

youjiali1995
Copy link
Contributor

Signed-off-by: youjiali1995 zlwgx1023@gmail.com

What is changed and how it works?

Disable green GC by default.

Related changes

  • Need to cherry-pick to the release branch

Need to remove the release note in #16951.

Check List

  • Unit test

Side effects

Release note

  • No release note

Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #17089 into master will decrease coverage by 0.0517%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #17089        +/-   ##
================================================
- Coverage   80.0329%   79.9811%   -0.0518%     
================================================
  Files           510        510                
  Lines        139059     138984        -75     
================================================
- Hits         111293     111161       -132     
- Misses        18809      18853        +44     
- Partials       8957       8970        +13     

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented May 11, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 11, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 11, 2020

/run-all-tests

@sre-bot sre-bot merged commit 8de9667 into pingcap:master May 11, 2020
sre-bot pushed a commit to sre-bot/tidb that referenced this pull request May 11, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 11, 2020

cherry pick to release-4.0 in PR #17092

jackysp pushed a commit that referenced this pull request May 11, 2020
Co-authored-by: Lei Zhao <zlwgx1023@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/GC status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants