-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gc_worker: disable green GC by default #17089
Merged
sre-bot
merged 2 commits into
pingcap:master
from
youjiali1995:disable-green-gc-by-default
May 11, 2020
Merged
gc_worker: disable green GC by default #17089
sre-bot
merged 2 commits into
pingcap:master
from
youjiali1995:disable-green-gc-by-default
May 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #17089 +/- ##
================================================
- Coverage 80.0329% 79.9811% -0.0518%
================================================
Files 510 510
Lines 139059 138984 -75
================================================
- Hits 111293 111161 -132
- Misses 18809 18853 +44
- Partials 8957 8970 +13 |
jackysp
reviewed
May 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MyonKeminta
approved these changes
May 11, 2020
/merge |
sre-bot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
May 11, 2020
/run-all-tests |
cherry pick to release-4.0 in PR #17092 |
jackysp
pushed a commit
that referenced
this pull request
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: youjiali1995 zlwgx1023@gmail.com
What is changed and how it works?
Disable green GC by default.
Related changes
Need to remove the release note in #16951.
Check List
Side effects
Release note