Skip to content

Commit

Permalink
gc_worker: disable green GC by default (#17089)
Browse files Browse the repository at this point in the history
  • Loading branch information
youjiali1995 authored May 11, 2020
1 parent d8c0659 commit 8de9667
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion store/tikv/gcworker/gc_worker.go
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ const (
gcScanLockModeKey = "tikv_gc_scan_lock_mode"
gcScanLockModeLegacy = "legacy"
gcScanLockModePhysical = "physical"
gcScanLockModeDefault = gcScanLockModePhysical
gcScanLockModeDefault = gcScanLockModeLegacy

gcAutoConcurrencyKey = "tikv_gc_auto_concurrency"
gcDefaultAutoConcurrency = true
Expand Down
2 changes: 1 addition & 1 deletion store/tikv/gcworker/gc_worker_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ func (s *testGCWorkerSuite) TestCheckGCMode(c *C) {
func (s *testGCWorkerSuite) TestCheckScanLockMode(c *C) {
usePhysical, err := s.gcWorker.checkUsePhysicalScanLock()
c.Assert(err, IsNil)
c.Assert(usePhysical, Equals, true)
c.Assert(usePhysical, Equals, false)
// This is a hidden config, so default value will not be inserted to table.
str, err := s.gcWorker.loadValueFromSysTable(gcScanLockModeKey)
c.Assert(err, IsNil)
Expand Down

0 comments on commit 8de9667

Please sign in to comment.