expression, planner: do not eliminate the innermost NOT when push down not (#16451) #16477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
sre-bot
added
component/expression
sig/planner
…e-bot/release-3.1-ab57dc61376a
XuHuaiyu
added
the
priority/release-blocker
|
/run-all-tests |
|
/run-sqllogic-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #16451 to release-3.1
What problem does this PR solve?
Issue Number: close #16440
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
Before this commit, we'll wrap a
IsTruefor the arg of the innermost NOT.But the implementation of IsTrue in TiDB is not the same as TiKV after #12173.
Even if we correct the implementation of IsTrue on TiKV, the parameter
keepNullcan not be pushed down on release-3.0 and release-3.1.Thus we do not eliminate the innermost NOT instead of wrapping a
IsTruehere.How it Works:
Related changes
Check List
Tests
Side effects
Release note