expression: fix incorrect result of logical operators

[sduzh]

What problem does this PR solve?

Fix #11199
Fix #11188

TiDB> SELECT NULL OR 0.00000001000000000000;
+--------------------------------+
| NULL OR 0.00000001000000000000 |
+--------------------------------+
|                              1 |
+--------------------------------+
1 row in set (0.00 sec)

TiDB> SELECT 0 OR 0.00000001000000000000;
+-----------------------------+
| 0 OR 0.00000001000000000000 |
+-----------------------------+
|                           1 |
+-----------------------------+
1 row in set (0.00 sec)

TiDB> SELECT 0 OR "0.01a";
+--------------+
| 0 OR "0.01a" |
+--------------+
|            1 |
+--------------+
1 row in set, 1 warning (0.00 sec)

What is changed and how it works?

Wrap the input parameters of the builtin AND、OR and XOR operators with IS TRUE function before cast them to int type.

Check List

Tests

• Unit test

Code changes

Side effects

Related changes

Release note

• fix incorrect result of logical operators (OR, AND)

[codecov]

Codecov Report

Merging #12173 into master will decrease coverage by 0.0466%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #12173        +/-   ##
================================================
- Coverage   79.9183%   79.8717%   -0.0467%     
================================================
  Files           462        462                
  Lines        104892     105101       +209     
================================================
+ Hits          83828      83946       +118     
- Misses        14910      14990        +80     
- Partials       6154       6165        +11

[zz-jason]

@sduzh should we directly modify builtinLogicOrSig to return 1 when the two input parameters are null and 1?

[sduzh]

@sduzh should we directly modify builtinLogicOrSig to return 1 when the two input parameters are null and 1?

@zz-jason Sorry, I didn't understand what you mean. Isn't this the current implementation?

[SunRunAway]

Hi, your PR looks really awesome. It would be better to take another look at other logical functions (https://dev.mysql.com/doc/refman/8.0/en/logical-operators.html), and fix them together.
Thanks again.

[CLAassistant]

All committers have signed the CLA.

[SunRunAway]

LGTM

[XuHuaiyu]

LGTM

[sre-bot]

Your auto merge job has been accepted, waiting for 12558, 12564, 12551, 12552, 12553

[sre-bot]

/run-all-tests

[sre-bot]

@sduzh merge failed.