Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix wrong result for index merge read generate column (#16002) #16359

Merged
merged 2 commits into from
Apr 15, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 14, 2020

cherry-pick #16002 to release-4.0


What problem does this PR solve?

Issue Number: close #15994

Problem Summary: When an index merge reader reads the generated column, it gets the wrong result. Because the generated column is ignored in the final table reader stage.

What is changed and how it works?

What's Changed: deal the generated column for final table reader.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU

@sre-bot sre-bot requested a review from a team as a code owner April 14, 2020 09:41
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 14, 2020

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 15, 2020
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 15, 2020
@zz-jason zz-jason added status/all-tests-passed status/can-merge Indicates a PR has been approved by a committer. labels Apr 15, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 15, 2020

Your auto merge job has been accepted, waiting for 16311, 16408

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 15, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 15, 2020

@sre-bot merge failed.

@zz-jason zz-jason merged commit 5cc93cc into pingcap:release-4.0 Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants