executor: fix wrong result for index merge read generate column #16002
Conversation
lzmhhh123
added
type/bugfix
ghost
requested review from
| @@ -189,6 +189,7 @@ func (e *IndexMergeReaderExecutor) startPartialIndexWorker(ctx context.Context, | |||
| SetKeepOrder(false). | |||
| SetStreaming(e.partialStreamings[workID]). | |||
| SetFromSessionVars(e.ctx.GetSessionVars()). | |||
| SetMemTracker(e.memTracker). | |||
There was a problem hiding this comment.
Probably yes. It affects the memory track for index merge reader in the index side.
Codecov Report
@@ Coverage Diff @@
## master #16002 +/- ##
===========================================
Coverage 80.7645% 80.7645%
===========================================
Files 506 506
Lines 138198 138198
===========================================
Hits 111615 111615
Misses 18078 18078
Partials 8505 8505 |
| @@ -50,3 +50,14 @@ func (s *testSuite1) TestJoin(c *C) { | |||
| tk.MustQuery("select /*+ use_index_merge(t1, t1a, t1b) */ sum(t1.a) from t1 join t2 on t1.id = t2.id where t1.a < 2 or t1.b > 4").Check(testkit.Rows("6")) | |||
| tk.MustQuery("select /*+ use_index_merge(t1, t1a, t1b) */ sum(t1.a) from t1 join t2 on t1.id = t2.id where t1.a < 2 or t1.b > 5").Check(testkit.Rows("1")) | |||
| } | |||
|
|
|||
| func (s *testSuite1) TestIndexMergeReaderAndGeneratedColumn(c *C) { | |||
| tk := testkit.NewTestKitWithInit(c, s.store) | |||
There was a problem hiding this comment.
Do we need to tk.MustExec("set tidb_enable_index_merge=1") ?
There was a problem hiding this comment.
No, the hint doesn't require tidb_enable_index_merge.
There was a problem hiding this comment.
ok, but I think it's a bug.
If we do not enable_index_merge, the hint should not take effect
There was a problem hiding this comment.
I don't want to interfere, but the documentation currently mentions the following:
IndexMerge is disabled by default. Enable the IndexMerge in one of two ways:
- Set the tidb_enable_index_merge system variable to 1;
- Use the SQL Hint USE_INDEX_MERGE in the query.
Note: The SQL Hint has a higher priority over the system variable.
francis0407
added
the
status/can-merge
|
/run-all-tests |
|
@lzmhhh123 merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for 16032, 16338 |
|
/run-all-tests |
|
cherry pick to release-4.0 in PR #16359 |
What problem does this PR solve?
Issue Number: close #15994
Problem Summary: When an index merge reader reads the generated column, it gets the wrong result. Because the generated column is ignored in the final table reader stage.
What is changed and how it works?
What's Changed: deal the generated column for final table reader.
Related changes
Check List
Tests
Side effects