Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: fix select * from inspection_summary would return null. #16099

Merged
merged 13 commits into from
Apr 10, 2020
Merged

infoschema: fix select * from inspection_summary would return null. #16099

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e8dff28
fix select * from inspection
reafans Apr 7, 2020
18091f3
refine test
reafans Apr 7, 2020
a445f2e
fix test
reafans Apr 7, 2020
266b424
refine
reafans Apr 7, 2020
530ef37
fix UT
reafans Apr 7, 2020
28191b1
test for no rule
reafans Apr 7, 2020
8acd7e7
refine UT
reafans Apr 7, 2020
90588dd
Merge branch 'master' into fix_inspection
reafans Apr 7, 2020
ca03812
address comment
reafans Apr 8, 2020
1f09952
Merge branch 'fix_inspection' of https://github.com/reafans/tidb into…
reafans Apr 8, 2020
cba0860
change comment length to 256
reafans Apr 9, 2020
9a941c1
Merge branch 'master' into fix_inspection
reafans Apr 9, 2020
7c869da
Merge branch 'master' into fix_inspection
sre-bot Apr 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address comment
  • Loading branch information
@reafans
reafans committed Apr 8, 2020
commit ca038125c05463c494acba3140f3b6554a35824a
6 changes: 2 additions & 4 deletions executor/inspection_summary.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,10 +422,8 @@ func (e *inspectionSummaryRetriever) retrieve(ctx context.Context, sctx sessionc
condition := e.timeRange.Condition()
var finalRows [][]types.Datum
for rule, tables := range inspectionSummaryRules {
if len(rules.set) != 0 {
if !rules.set.Exist(rule) {
continue
}
if len(rules.set) != 0 && !rules.set.Exist(rule) {
continue
}
for _, name := range tables {
if !names.enable(name) {
Expand Down