infoschema: fix select * from inspection_summary would return null. #16099

reafans · 2020-04-07T05:42:54Z

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

Currently it would return empty results without rule condition.

What is changed and how it works?

Make it return all the results for select * from inspection.
Add a column name COMMENT to explain the row.

What's Changed:
before:

mysql> select * from inspection_summary;
Empty set (0.00 sec)

this pr :

mysql> select * from inspection_summary limit 10;
+-------+------------------+------------------------------------------+----------------+----------+-----------+-----------+-----------+------------------------------------------------------------------------------------------------------+
| RULE  | INSTANCE         | METRICS_NAME                             | LABEL          | QUANTILE | AVG_VALUE | MIN_VALUE | MAX_VALUE | COMMENT                                                                                              |
+-------+------------------+------------------------------------------+----------------+----------+-----------+-----------+-----------+------------------------------------------------------------------------------------------------------+
| stats | gncluster-tidb-0 | tidb_statistics_auto_analyze_duration    |                |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB auto analyze time durations within 95 percent histogram buckets                 |
| stats | gncluster-tidb-0 | tidb_statistics_fast_analyze_status      | access_regions |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB fast analyze statistics                                                         |
| stats | gncluster-tidb-0 | tidb_statistics_fast_analyze_status      | region_error   |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB fast analyze statistics                                                         |
| stats | gncluster-tidb-0 | tidb_statistics_fast_analyze_status      | sample         |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB fast analyze statistics                                                         |
| stats | gncluster-tidb-0 | tidb_statistics_fast_analyze_status      | scan_keys      |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB fast analyze statistics                                                         |
| stats | gncluster-tidb-0 | tidb_statistics_fast_analyze_status      | seek_keys      |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB fast analyze statistics                                                         |
| stats |                  | tidb_statistics_pseudo_estimation_ops    |                |     NULL |  0.000000 |  0.000000 |  0.000000 | TiDB optimizer using pseudo estimation counts                                                        |
| stats |                  | tidb_statistics_significant_feedback     |                |     NULL |  0.000000 |  0.000000 |  0.000000 | Counter of query feedback whose actual count is much different than calculated by current statistics |
| stats | gncluster-tidb-0 | tidb_statistics_stats_inaccuracy_rate    |                |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB statistics inaccurate rate                                                      |
| stats | gncluster-tidb-0 | tidb_statistics_store_query_feedback_qps | ok             |     NULL |  0.044445 |  0.044443 |  0.044445 | TiDB store quering feedback counts                                                                   |
+-------+------------------+------------------------------------------+----------------+----------+-----------+-----------+-----------+------------------------------------------------------------------------------------------------------+
10 rows in set (21.26 sec)

mysql> select * from inspection_summary where rule='query-summary' and metrics_name='tidb_query_duration';
+---------------+------------------+---------------------+----------+----------+-----------+-----------+-----------+----------------------------------------------+
| RULE          | INSTANCE         | METRICS_NAME        | LABEL    | QUANTILE | AVG_VALUE | MIN_VALUE | MAX_VALUE | COMMENT                                      |
+---------------+------------------+---------------------+----------+----------+-----------+-----------+-----------+----------------------------------------------+
| query-summary | gncluster-tidb-0 | tidb_query_duration | Begin    |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB query durations(second) |
| query-summary | gncluster-tidb-0 | tidb_query_duration | Commit   |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB query durations(second) |
| query-summary | gncluster-tidb-0 | tidb_query_duration | Delete   |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB query durations(second) |
| query-summary | gncluster-tidb-0 | tidb_query_duration | Execute  |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB query durations(second) |
| query-summary | gncluster-tidb-0 | tidb_query_duration | Insert   |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB query durations(second) |
| query-summary | gncluster-tidb-0 | tidb_query_duration | Replace  |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB query durations(second) |
| query-summary | gncluster-tidb-0 | tidb_query_duration | Rollback |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB query durations(second) |
| query-summary | gncluster-tidb-0 | tidb_query_duration | Select   |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB query durations(second) |
| query-summary | gncluster-tidb-0 | tidb_query_duration | Set      |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB query durations(second) |
| query-summary | gncluster-tidb-0 | tidb_query_duration | Show     |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB query durations(second) |
| query-summary | gncluster-tidb-0 | tidb_query_duration | Update   |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB query durations(second) |
| query-summary | gncluster-tidb-0 | tidb_query_duration | Use      |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB query durations(second) |
| query-summary | gncluster-tidb-0 | tidb_query_duration | general  |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB query durations(second) |
| query-summary | gncluster-tidb-0 | tidb_query_duration | internal |     0.99 |  0.004050 |  0.003934 |  0.005480 | The quantile of TiDB query durations(second) |
+---------------+------------------+---------------------+----------+----------+-----------+-----------+-----------+----------------------------------------------+
14 rows in set (0.09 sec)

Related changes

PR to update pingcap/docs/pingcap/docs-cn:

Check List

Tests

Unit test
Integration test

Release note

codecov · 2020-04-07T08:03:45Z

Codecov Report

Merging #16099 into master will not change coverage by %.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #16099   +/-   ##
===========================================
  Coverage   80.4052%   80.4052%           
===========================================
  Files           506        506           
  Lines        136251     136251           
===========================================
  Hits         109553     109553           
  Misses        18182      18182           
  Partials       8516       8516

reafans · 2020-04-07T08:16:59Z

/run-all-tests

reafans · 2020-04-07T08:26:57Z

/run-integration-copr-test

reafans · 2020-04-07T08:34:26Z

/run-integration-copr-test

zimulala

LGTM

executor/inspection_summary.go

… fix_inspection

infoschema/tables.go

crazycs520

LGTM

reafans · 2020-04-10T09:04:05Z

/merge

sre-bot · 2020-04-10T09:06:41Z

/run-all-tests

sre-bot · 2020-04-10T09:09:41Z

@reafans merge failed.

reafans · 2020-04-10T09:13:32Z

/run-integration-copr-test

reafans · 2020-04-10T09:16:38Z

/run-sqllogic-test-2

reafans · 2020-04-10T09:20:29Z

/merge

sre-bot · 2020-04-10T09:20:40Z

/run-all-tests

…ingcap#16099)

…16099) (#17697)

fix select * from inspection

e8dff28

reafans requested a review from a team as a code owner April 7, 2020 05:42

ghost requested review from qw4990 and removed request for a team April 7, 2020 05:43

github-actions bot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution labels Apr 7, 2020

reafans changed the title ~~infoschema: fix select * from inspection would return null.~~ infoschema: fix select * from inspection_summary would return null. Apr 7, 2020

reafans added 4 commits April 7, 2020 15:24

refine test

18091f3

fix test

a445f2e

refine

266b424

fix UT

530ef37

reafans added 2 commits April 7, 2020 16:03

test for no rule

28191b1

refine UT

8acd7e7

Merge branch 'master' into fix_inspection

90588dd

zimulala reviewed Apr 8, 2020

View reviewed changes

zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 8, 2020

crazycs520 reviewed Apr 8, 2020

View reviewed changes

executor/inspection_summary.go Outdated Show resolved Hide resolved

reafans added 2 commits April 9, 2020 00:28

address comment

ca03812

Merge branch 'fix_inspection' of https://github.com/reafans/tidb into…

1f09952

… fix_inspection

crazycs520 reviewed Apr 9, 2020

View reviewed changes

infoschema/tables.go Outdated Show resolved Hide resolved

reafans and others added 2 commits April 9, 2020 11:10

change comment length to 256

cba0860

Merge branch 'master' into fix_inspection

9a941c1

qw4990 removed their request for review April 9, 2020 08:01

crazycs520 reviewed Apr 10, 2020

View reviewed changes

crazycs520 approved these changes Apr 10, 2020

View reviewed changes

sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 10, 2020

Merge branch 'master' into fix_inspection

7c869da

reafans removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 10, 2020

sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 10, 2020

sre-bot merged commit 8891c9d into pingcap:master Apr 10, 2020

reafans deleted the fix_inspection branch April 10, 2020 09:25

crazycs520 pushed a commit to crazycs520/tidb that referenced this pull request Jun 5, 2020

infoschema: fix select * from inspection_summary would return null. (p…

60a9310

…ingcap#16099)

crazycs520 mentioned this pull request Jun 5, 2020

infoschema: fix select * from inspection_summary would return null. (#16099) #17697

Merged

zimulala pushed a commit that referenced this pull request Jun 5, 2020

infoschema: fix select * from inspection_summary would return null. (#…

312fdb6

…16099) (#17697)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

infoschema: fix select * from inspection_summary would return null. #16099

infoschema: fix select * from inspection_summary would return null. #16099

reafans commented Apr 7, 2020 •

edited

Loading

codecov bot commented Apr 7, 2020 •

edited

Loading

reafans commented Apr 7, 2020

reafans commented Apr 7, 2020

reafans commented Apr 7, 2020

zimulala left a comment

crazycs520 left a comment

reafans commented Apr 10, 2020

sre-bot commented Apr 10, 2020

sre-bot commented Apr 10, 2020

reafans commented Apr 10, 2020

reafans commented Apr 10, 2020

reafans commented Apr 10, 2020

sre-bot commented Apr 10, 2020

infoschema: fix select * from inspection_summary would return null. #16099

infoschema: fix select * from inspection_summary would return null. #16099

Conversation

reafans commented Apr 7, 2020 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Related changes

Check List

Release note

codecov bot commented Apr 7, 2020 • edited Loading

Codecov Report

reafans commented Apr 7, 2020

reafans commented Apr 7, 2020

reafans commented Apr 7, 2020

zimulala left a comment

Choose a reason for hiding this comment

crazycs520 left a comment

Choose a reason for hiding this comment

reafans commented Apr 10, 2020

sre-bot commented Apr 10, 2020

sre-bot commented Apr 10, 2020

reafans commented Apr 10, 2020

reafans commented Apr 10, 2020

reafans commented Apr 10, 2020

sre-bot commented Apr 10, 2020

reafans commented Apr 7, 2020 •

edited

Loading

codecov bot commented Apr 7, 2020 •

edited

Loading