Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix decimal of function FROM_UNIXTIME (#14936) #15269

Closed
wants to merge 6 commits into from
Closed

expression: fix decimal of function FROM_UNIXTIME (#14936) #15269

wants to merge 6 commits into from

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 10, 2020

cherry-pick #14936 to release-2.1

What problem does this PR solve?

Fix #14935

What is changed and how it works?

Check List

Tests

  • Unit test

@SunRunAway @sre-bot
cherry pick pingcap#14936 to release-2.1
e2f3244 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 10, 2020

/run-all-tests

@sre-bot sre-bot mentioned this pull request Mar 10, 2020
Merged
zz-jason
zz-jason reviewed Mar 10, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 12, 2020

@zz-jason, @XuHuaiyu, @wshwsh12, PTAL.

1 similar comment
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 14, 2020

@zz-jason, @XuHuaiyu, @wshwsh12, PTAL.

wshwsh12
wshwsh12 reviewed Mar 15, 2020
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the CI. LGTM

@SunRunAway
Copy link
Contributor

Please fix the CI. LGTM

Blocked by #15357

@XuHuaiyu XuHuaiyu removed their request for review March 16, 2020 06:10
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 17, 2020

@zz-jason, @wshwsh12, PTAL.

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 19, 2020

@zz-jason, @wshwsh12, PTAL.

1 similar comment
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 22, 2020

@zz-jason, @wshwsh12, PTAL.

@SunRunAway
Copy link
Contributor

Abandoning this PR because what blocks it (#15357) is not resolved.

@SunRunAway SunRunAway closed this Aug 12, 2020
@SunRunAway SunRunAway deleted the release-2.1-7c39e5e5e0bc branch August 12, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@wshwsh12 wshwsh12 wshwsh12 left review comments

Assignees
No one assigned
Labels
component/expression type/bugfix This PR fixes a bug. type/2.1-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sre-bot @SunRunAway @zz-jason @wshwsh12 @zhouqiang-cl