Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix decimal of function FROM_UNIXTIME #14936

Merged
merged 6 commits into from
Mar 10, 2020

Conversation

SunRunAway
Copy link
Contributor

What problem does this PR solve?

Fix #14935

What is changed and how it works?

Check List

Tests

  • Unit test

@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #14936 into master will not change coverage by %.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #14936   +/-   ##
===========================================
  Coverage   80.5452%   80.5452%           
===========================================
  Files           503        503           
  Lines        134152     134152           
===========================================
  Hits         108053     108053           
  Misses        17700      17700           
  Partials       8399       8399           

@SunRunAway SunRunAway marked this pull request as ready for review February 25, 2020 11:54
@SunRunAway SunRunAway requested a review from a team as a code owner February 25, 2020 11:54
@SunRunAway SunRunAway requested review from XuHuaiyu, zz-jason, csuzhangxc, qw4990 and wshwsh12 and removed request for a team and csuzhangxc February 25, 2020 11:57
@sre-bot
Copy link
Contributor

sre-bot commented Feb 27, 2020

@zz-jason, @qw4990, @XuHuaiyu, @wshwsh12, PTAL.

1 similar comment
@sre-bot
Copy link
Contributor

sre-bot commented Feb 29, 2020

@zz-jason, @qw4990, @XuHuaiyu, @wshwsh12, PTAL.

zz-jason
zz-jason previously approved these changes Mar 3, 2020
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason dismissed their stale review March 3, 2020 07:04

needs one more LGTM from another reviewer

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 3, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 5, 2020

@zz-jason, @qw4990, @XuHuaiyu, @wshwsh12, PTAL.

1 similar comment
@sre-bot
Copy link
Contributor

sre-bot commented Mar 7, 2020

@zz-jason, @qw4990, @XuHuaiyu, @wshwsh12, PTAL.

@sre-bot
Copy link
Contributor

sre-bot commented Mar 10, 2020

@zz-jason, @qw4990, @XuHuaiyu, @wshwsh12, PTAL.

Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 10, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 10, 2020

Your auto merge job has been accepted, waiting for 15096, 15241

@sre-bot
Copy link
Contributor

sre-bot commented Mar 10, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Mar 10, 2020

@SunRunAway merge failed.

@qw4990 qw4990 removed their request for review March 10, 2020 08:01
@qw4990
Copy link
Contributor

qw4990 commented Mar 10, 2020

/run-all-tests

@SunRunAway
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 10, 2020

/run-all-tests

@sre-bot sre-bot merged commit 7c39e5e into pingcap:master Mar 10, 2020
@SunRunAway SunRunAway deleted the from_unixtime_decimal branch March 10, 2020 13:36
sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Mar 10, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Mar 10, 2020

cherry pick to release-2.1 in PR #15269

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Mar 10, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Mar 10, 2020

cherry pick to release-3.0 in PR #15270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the decimal part of FROM_UNIXTIME is different from MySQL
6 participants