Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: merge overlapped ranges when build key ranges for indexJoin #14596

Merged
merged 4 commits into from
Feb 3, 2020

Conversation

francis0407
Copy link
Member

What problem does this PR solve?

fix #14534

What is changed and how it works?

When indexJoin's inner range is decided by more than one condition, it may generate overlapped ranges for inner side which might lead to incorrect result.

This PR merges the overlapped ranges.

Check List

Tests

  • Unit test

Side effects

  • Possible performance regression

Related changes

  • Need to cherry-pick to the release-3.0

Release note

  • Fix the bug that IndexJoin may get wrong results when inner range is decided by more than one condition.

@francis0407 francis0407 added type/bugfix This PR fixes a bug. sig/execution SIG execution labels Feb 3, 2020
@francis0407 francis0407 added this to the v4.0.0-beta.1 milestone Feb 3, 2020
@francis0407 francis0407 requested review from winoros and eurekaka and removed request for winoros February 3, 2020 06:43
@francis0407
Copy link
Member Author

/run-all-tests

1 similar comment
@francis0407
Copy link
Member Author

/run-all-tests

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francis0407
Copy link
Member Author

/run-unit-test

@francis0407 francis0407 added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 3, 2020
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 3, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 3, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Feb 3, 2020

cherry pick to release-3.0 in PR #14599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

executor: IndexJoin get wrong results when inner range is decided by more than one condition
4 participants