Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: merge overlapped ranges when build key ranges for indexJoin (#14596) #14599

Merged
merged 5 commits into from
Feb 4, 2020
Merged

executor: merge overlapped ranges when build key ranges for indexJoin (#14596) #14599

merged 5 commits into from
Feb 4, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Feb 3, 2020

cherry-pick #14596 to release-3.0

What problem does this PR solve?

fix #14534

What is changed and how it works?

When indexJoin's inner range is decided by more than one condition, it may generate overlapped ranges for inner side which might lead to incorrect result.

This PR merges the overlapped ranges.

Check List

Tests

  • Unit test

Side effects

  • Possible performance regression

Related changes

  • Need to cherry-pick to the release-3.0

Release note

  • Fix the bug that IndexJoin may get wrong results when inner range is decided by more than one condition.

@sre-bot
Copy link
Contributor Author

sre-bot commented Feb 3, 2020

/run-all-tests

@sre-bot sre-bot mentioned this pull request Feb 3, 2020
Merged
@sre-bot sre-bot added sig/execution SIG execution type/3.0 cherry-pick type/bugfix This PR fixes a bug. labels Feb 3, 2020
eurekaka
eurekaka reviewed Feb 3, 2020
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

zz-jason commented Feb 3, 2020 

[2020-02-03T09:59:13.455Z] vet: executor/index_lookup_join_test.go:172:10: undeclared name: testSuite5

@francis0407 please fix CI

@francis0407
Copy link
Member

/run-all-tests

@francis0407 francis0407 added this to the v3.0.10 milestone Feb 4, 2020
@francis0407
Copy link
Member

@zz-jason PTAL

zz-jason
zz-jason approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Feb 4, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Feb 4, 2020

/run-all-tests

@sre-bot sre-bot merged commit 6441e1f into pingcap:release-3.0 Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurekaka eurekaka eurekaka left review comments

@zz-jason zz-jason zz-jason approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
v3.0.10
Development

Successfully merging this pull request may close these issues.
4 participants
@sre-bot @zz-jason @francis0407 @eurekaka