-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add builtin aggregate function VAR_POP
#14101
Conversation
update the branch new_varpop with lastest code from remote branch upstream/master
Hi @githubFZX,
You can run |
VAR_POP
Why does the above error occur in unit test?I just modify go.mod to update parser. I need help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But I want to know why update tipb, atomic, zap, tools in go.mod ? Only parser is not enough?
I used command ”GO111MODULE=on go get -u github.com/pingcap/parser@master“ to update parser. But the others changed together. |
@githubFZX @wshwsh12 you can run |
Ok, thank you! |
@githubFZX any update? BTW, this PR is conflicted with the master branch, please use |
Ok, i will fix it later. |
@githubFZX It seems that someone has updated parser in other pr. Now we can reset the go.mod and go.sum to master and merge this pr . |
LGTM |
Your auto merge job has been accepted, waiting for 14361 |
/run-all-tests |
1 similar comment
/run-all-tests |
@githubFZX merge failed. |
There is no error when I use commands "make test" and "make dev" in my local machine. What should I do to resolve this problem that unit-test can not pass? |
What problem does this PR solve?
#7623
What is changed and how it works?
Implement builtin aggregate function 'varpop' in tidb and use the algorithm described by Chan, Golub, and LeVeque in "Algorithms for computing the sample variance: analysis and recommendations" to calculate the variance.
Check List
Tests