Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call For Participation: finish the unsupported aggregate functions #7623

Closed
6 tasks done
zz-jason opened this issue Sep 5, 2018 · 14 comments · Fixed by #19957
Closed
6 tasks done

Call For Participation: finish the unsupported aggregate functions #7623

zz-jason opened this issue Sep 5, 2018 · 14 comments · Fixed by #19957
Labels
challenge-program feature/accepted This feature request is accepted by product managers help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/P3 The issue has P3 priority. Assigned to backlog. sig/execution SIG execution type/compatibility type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@zz-jason
Copy link
Member

zz-jason commented Sep 5, 2018 •
edited by morgo
Loading

All issues are open and welcomed to contributors. You can join #sig-exec on tidb community slack to discuss and get help from someone.

Description

At present, the aggregate functions that TiDB supports are:

  • AVG()
  • BIT_AND()
  • BIT_OR()
  • BIT_XOR()
  • COUNT()
  • COUNT(DISTINCT)
  • GROUP_CONCAT()
  • MAX()
  • MIN()
  • SUM()

In order to be compatible with MySQL and Improve the usability of TiDB, the following functions should also be supported in TiDB:

Name Description
STD() Alias for STDDEV_POP function
STDDEV() Alias for STDDEV_POP function
STDDEV_POP() Return the population standard deviation
STDDEV_SAMP() Return the sample standard deviation
VARIANCE() Return the population standard variance
VAR_POP() Return the population standard variance
VAR_SAMP() Return the sample variance
JSON_ARRAYAGG() Return result set as a single JSON array
JSON_OBJECTAGG() Return result set as a single JSON object

An implementation checklist:

Difficulty

  • Medium

Score

  • 3000

Mentor(s)

Recommended Skills

  • SQL Optimization
  • Golang Profiling
  • Code Refactoring
@zz-jason zz-jason added the sig/execution SIG execution label Sep 5, 2018
@zz-jason zz-jason self-assigned this Sep 5, 2018
@zz-jason zz-jason added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 7, 2018
@zz-jason zz-jason mentioned this issue Sep 7, 2018
Closed
28 tasks
@mccxj mccxj mentioned this issue Sep 16, 2018
Closed
@lzmhhh123 lzmhhh123 mentioned this issue Sep 21, 2018
Closed
@Kingwl Kingwl mentioned this issue Sep 30, 2018
Closed
@ngaut ngaut mentioned this issue Nov 24, 2018
Closed
11 tasks
@XuHuaiyu XuHuaiyu mentioned this issue Nov 29, 2018
Merged
@hg2990656 hg2990656 mentioned this issue Jul 9, 2019
Merged
@githubFZX githubFZX mentioned this issue Jul 9, 2019
Closed
@githubFZX githubFZX mentioned this issue Dec 18, 2019
Merged
@qw4990 qw4990 mentioned this issue Jan 15, 2020
Open
24 tasks
@zz-jason zz-jason changed the title implement the rest of unsupported aggregate functions Call For Participation: finish the unsupported aggregate functions Jan 21, 2020
@SunRunAway SunRunAway mentioned this issue Jan 21, 2020
Closed
55 tasks
@ghost ghost mentioned this issue Jul 30, 2020
Closed
@zz-jason zz-jason removed their assignment Aug 5, 2020
@Win-Man
Copy link
Contributor

Win-Man commented Aug 5, 2020 •
edited
Loading

Pick up

@Win-Man Win-Man mentioned this issue Aug 13, 2020
Merged
@ghost ghost added priority/P3 The issue has P3 priority. Assigned to backlog. type/compatibility labels Aug 13, 2020
@zz-jason zz-jason added type/feature-request Categorizes issue or PR as related to a new feature. feature/accepted This feature request is accepted by product managers labels Aug 14, 2020
@Win-Man Win-Man mentioned this issue Aug 14, 2020
Merged
This was referenced Aug 27, 2020
Merged
Merged
@ti-challenge-bot
Copy link

Pick up success.

@qw4990 qw4990 mentioned this issue Sep 4, 2020
Closed
@Win-Man Win-Man mentioned this issue Sep 5, 2020
Merged
@ti-challenge-bot
Copy link

This issue already picked by Blue-Sail.

1 similar comment
@ti-challenge-bot
Copy link

This issue already picked by Blue-Sail.

@ti-challenge-bot ti-challenge-bot bot removed the picked label Sep 8, 2020
@ti-challenge-bot
Copy link

Give up success.

@arthuryangcs
Copy link
Contributor

/pick-up JSON_ARRAYAGG

@ti-challenge-bot
Copy link

Pick up success.

This was referenced Sep 11, 2020
Merged
Merged
This was referenced Sep 16, 2020
Merged
Merged
@ti-challenge-bot
Copy link

@arthuryangcs You did not submit PR within 7 days, so give up automatically.

@ti-challenge-bot ti-challenge-bot bot removed the picked label Sep 17, 2020
@arthuryangcs
Copy link
Contributor

/pick-up JSON_ARRAYAGG

@ti-challenge-bot
Copy link

Pick up success.

@ti-challenge-bot
Copy link

@arthuryangcs You did not submit PR within 7 days, so give up automatically.

@ti-challenge-bot ti-challenge-bot bot removed the picked label Sep 25, 2020
@arthuryangcs
Copy link
Contributor

/pick-up JSON_ARRAYAGG

@ti-challenge-bot
Copy link

Pick up success.

@ti-challenge-bot
Copy link

@arthuryangcs You did not submit PR within 7 days, so give up automatically.

@ti-challenge-bot ti-challenge-bot bot removed the picked label Oct 6, 2020
@ichn-hu ichn-hu mentioned this issue Nov 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
challenge-program feature/accepted This feature request is accepted by product managers help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/P3 The issue has P3 priority. Assigned to backlog. sig/execution SIG execution type/compatibility type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

executor: add builtin aggregate function json_arrayagg arthuryangcs/tidb
6 participants
@AndreMouche @zz-jason @arthuryangcs @qw4990 @Win-Man @ti-srebot