Skip to content

docker: update go version to 1.13 (#13021) #13030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2019
Merged

docker: update go version to 1.13 (#13021) #13030

merged 1 commit into from
Oct 30, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Oct 30, 2019

cherry-pick #13021 to release-3.0

Signed-off-by: cwen0 cwenyin0@gmail.com

What problem does this PR solve?

fix build tidb image issue

go: finding golang.org/x/sync v0.0.0-20181108010431-42b317875d0f
go: error loading module requirements
The command '/bin/sh -c GO111MODULE=on go mod download' returned a non-zero code: 1

What is changed and how it works?

update go version to 1.13

docker build -t hub.pingcap.net/cwen/tidb:latest . 
...
Successfully built 532658314be8
Successfully tagged hub.pingcap.net/cwen/tidb:latest

@cwen0 @sre-bot
docker: update go version to 1.13
9bc93a3 
Signed-off-by: cwen0 <cwenyin0@gmail.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Oct 30, 2019

/run-all-tests

@sre-bot sre-bot mentioned this pull request Oct 30, 2019
Merged
@sre-bot sre-bot requested review from ngaut and zimulala October 30, 2019 09:14
ngaut
ngaut approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@ngaut ngaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zimulala
zimulala reviewed Oct 30, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala merged commit 8d55be9 into pingcap:release-3.0 Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@ngaut ngaut ngaut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sre-bot @ngaut @zimulala @cwen0