Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: update go version to 1.13 #13021

Merged
merged 2 commits into from
Oct 30, 2019
Merged

docker: update go version to 1.13 #13021

merged 2 commits into from
Oct 30, 2019

Conversation

cwen0
Copy link
Member

@cwen0 cwen0 commented Oct 30, 2019

Signed-off-by: cwen0 cwenyin0@gmail.com

What problem does this PR solve?

fix build tidb image issue

go: finding golang.org/x/sync v0.0.0-20181108010431-42b317875d0f
go: error loading module requirements
The command '/bin/sh -c GO111MODULE=on go mod download' returned a non-zero code: 1

What is changed and how it works?

update go version to 1.13

docker build -t hub.pingcap.net/cwen/tidb:latest . 
...
Successfully built 532658314be8
Successfully tagged hub.pingcap.net/cwen/tidb:latest

@cwen0
docker: update go version to 1.13
199ffa1 
Signed-off-by: cwen0 <cwenyin0@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Oct 30, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

zimulala
zimulala reviewed Oct 30, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 30, 2019
@cwen0
Copy link
Member Author

cwen0 commented Oct 30, 2019

/run-unit-test

@codecov
Copy link

codecov bot commented Oct 30, 2019 •
edited
Loading

Codecov Report

Merging #13021 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13021   +/-   ##
===========================================
  Coverage   80.0409%   80.0409%           
===========================================
  Files           468        468           
  Lines        109369     109369           
===========================================
  Hits          87540      87540           
  Misses        15119      15119           
  Partials       6710       6710

ngaut
ngaut approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@ngaut ngaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngaut ngaut added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 30, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 30, 2019

Your auto merge job has been accepted, waiting for 12982

@sre-bot
Copy link
Contributor

sre-bot commented Oct 30, 2019

/run-all-tests

@sre-bot sre-bot merged commit 04a5c6a into pingcap:master Oct 30, 2019
@sre-bot sre-bot mentioned this pull request Oct 30, 2019
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Oct 30, 2019

cherry pick to release-3.1 in PR #13029

@sre-bot sre-bot mentioned this pull request Oct 30, 2019
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Oct 30, 2019

cherry pick to release-3.0 in PR #13030

@sre-bot sre-bot mentioned this pull request Oct 30, 2019
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Oct 30, 2019

cherry pick to release-2.1 in PR #13031

@cwen0 cwen0 deleted the cwen/update_dockerfile branch October 30, 2019 12:07
zz-jason pushed a commit that referenced this pull request Oct 30, 2019
@sre-bot @zz-jason
docker: update go version to 1.13 (#13021) (#13031)
a2f06f6
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@cwen0 @XiaTianliang
docker: update go version to 1.13 (pingcap#13021)
84bed1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@ngaut ngaut ngaut approved these changes

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cwen0 @CLAassistant @sre-bot @ngaut @zimulala