Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infoschema: handle partition table for tables (#12591) #12632

Merged
merged 2 commits into from
Oct 12, 2019
Merged

infoschema: handle partition table for tables (#12591) #12632

merged 2 commits into from
Oct 12, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Oct 11, 2019

Cherry pick #12591
Conflicts tables_test.go

When build fields lile data_length for information_schema.tables, we need to handle partition tables, because every partition would have their own stats.

What is changed and how it works?

Sum up each partition's info to build data length fields for table.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • Need to cherry-pick to the release branch

Release note

  • caculate data length for partition tables in information_schema.tables

winoros
winoros reviewed Oct 11, 2019
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

lzmhhh123
lzmhhh123 approved these changes Oct 12, 2019
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 12, 2019
@ngaut ngaut added the status/can-merge Indicates a PR has been approved by a committer. label Oct 12, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 12, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Oct 12, 2019

@lamxTyler merge failed.

@alivxxx
Copy link
Contributor Author

alivxxx commented Oct 12, 2019

/rebuild

@ngaut ngaut merged commit 9ca4666 into pingcap:release-3.1 Oct 12, 2019
@alivxxx alivxxx deleted the pingcap/release-3.1 branch October 12, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@eurekaka eurekaka Awaiting requested review from eurekaka

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alivxxx @sre-bot @winoros @lzmhhh123 @ngaut