Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: handle partition table for tables #12591

Merged
merged 2 commits into from
Oct 11, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Oct 10, 2019

What problem does this PR solve?

When build fields lile data_length for information_schema.tables, we need to handle partition tables, because every partition would have their own stats.

What is changed and how it works?

Sum up each partition's info to build data length fields for table.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • Need to cherry-pick to the release branch

Release note

  • caculate data length for partition tables in information_schema.tables

@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #12591 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12591   +/-   ##
===========================================
  Coverage   79.9119%   79.9119%           
===========================================
  Files           460        460           
  Lines        104042     104042           
===========================================
  Hits          83142      83142           
  Misses        14811      14811           
  Partials       6089       6089

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lzmhhh123 lzmhhh123 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Oct 11, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 11, 2019

/run-all-tests

@sre-bot sre-bot merged commit 38cd04f into pingcap:master Oct 11, 2019
@alivxxx alivxxx deleted the partition-info branch October 11, 2019 11:02
@sre-bot
Copy link
Contributor

sre-bot commented Oct 11, 2019

cherry pick to release-3.0 failed

@sre-bot
Copy link
Contributor

sre-bot commented Oct 11, 2019

cherry pick to release-3.1 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants