restore: fix error lost in create schema

lightning/restore/tidb.go

@@ -22,12 +22,14 @@ import (
 
 	tmysql "github.com/go-sql-driver/mysql"
 	"github.com/pingcap/errors"
+	"github.com/pingcap/failpoint"
 	"github.com/pingcap/parser"
 	"github.com/pingcap/parser/ast"
 	"github.com/pingcap/parser/format"
 	"github.com/pingcap/parser/model"
 	"github.com/pingcap/parser/mysql"
 	"github.com/pingcap/parser/terror"
+
 	"github.com/pingcap/tidb-lightning/lightning/glue"
 
 	. "github.com/pingcap/tidb-lightning/lightning/checkpoints"
@@ -154,6 +156,7 @@ func InitSchema(ctx context.Context, g glue.Glue, database string, tablesSchema
 
 	task := logger.Begin(zap.InfoLevel, "create tables")
 	var sqlCreateStmts []string
+loopCreate:
 	for tbl, sqlCreateTable := range tablesSchema {
 		task.Debug("create table", zap.String("schema", sqlCreateTable))
 
@@ -170,8 +173,11 @@ func InitSchema(ctx context.Context, g glue.Glue, database string, tablesSchema
 				"create table",
 				logger.With(zap.String("table", common.UniqueTable(database, tbl))),
 			)
+			failpoint.Inject("sqlCreateStmts", func() {
+				err = errors.Errorf("create %s failed", tbl)
+			})
 			if err != nil {
-				break
+				break loopCreate
 			}
 		}
 	}

lightning/restore/tidb_test.go

@@ -22,6 +22,7 @@ import (
 	"github.com/go-sql-driver/mysql"
 	. "github.com/pingcap/check"
 	"github.com/pingcap/errors"
+	"github.com/pingcap/failpoint"
 	"github.com/pingcap/parser/ast"
 	"github.com/pingcap/parser/model"
 	tmysql "github.com/pingcap/parser/mysql"
@@ -224,6 +225,25 @@ func (s *tidbSuite) TestInitSchemaSyntaxError(c *C) {
 	c.Assert(err, NotNil)
 }
 
+func (s *tidbSuite) TestInitSchemaErrorLost(c *C) {
+	ctx := context.Background()
+
+	s.mockDB.
+		ExpectExec("CREATE DATABASE IF NOT EXISTS `db`").
+		WillReturnResult(sqlmock.NewResult(1, 1))
+	s.mockDB.
+		ExpectClose()
+
+	failpoint.Enable("github.com/pingcap/tidb-lightning/lightning/restore/sqlCreateStmts", "1*return")
+	err := InitSchema(ctx, s.tiGlue, "db", map[string]string{
+		"t1": "create table `t1` (a int);",
+		"t2": "create table t2 (a int primary key, b varchar(200));",
+	})
+	failpoint.Disable("github.com/pingcap/tidb-lightning/lightning/restore/sqlCreateStmts")
+	// cannot predict which table will failed since map is unorder.
+	c.Assert(err, ErrorMatches, "create (.*) failed")
+}
+
 func (s *tidbSuite) TestInitSchemaUnsupportedSchemaError(c *C) {
 	ctx := context.Background()