This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
restore: fix error lost in create schema #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glorv
reviewed
Dec 23, 2020
lightning/restore/tidb.go
Outdated
| for tbl := range tablesSchema { | ||
| tables = append(tables, tbl) | ||
| } | ||
| // sort tables for failpoint test |
There was a problem hiding this comment.
I think a better solution is to use regexp to match the execute result in failpoint test
glorv
reviewed
Dec 23, 2020
lightning/restore/tidb.go
Outdated
| ) | ||
| failpoint.Inject("sqlCreateStmts", func() { | ||
| if i == 0 { |
There was a problem hiding this comment.
if the count matters, I think you can add an int parameter to this fail-point to determine at which condition, it should return an error. So maybe we can test with the error returns at first, middle or last position.
glorv
reviewed
Dec 23, 2020
kennytm
reviewed
Dec 23, 2020
kennytm
reviewed
Dec 23, 2020
|
LGTM |
ti-srebot
added
status/LGT2
ti-srebot
approved these changes
Dec 23, 2020
|
/merge |
|
/run-all-tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix pingcap/tidb#21827
What is changed and how it works?
break create loop immediately when error encountered
Check List
Tests
Related changes
Release note: