Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

restore: add local checksum log #153

Merged
merged 2 commits into from
Mar 27, 2019
Merged

restore: add local checksum log #153

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cdf061
restore: add local checksum log
lonng Mar 27, 2019
6b5cd4c
Update lightning/restore/restore.go
kennytm Mar 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions lightning/restore/restore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -824,12 +824,20 @@ func (t *TableRestore) postProcess(ctx context.Context, rc *RestoreController, c
}

// 4. do table checksum
var localChecksum verify.KVChecksum
for _, engine := range cp.Engines {
for _, chunk := range engine.Chunks {
localChecksum.Add(&chunk.Checksum)
}
}
common.AppLogger.Errorf("[%s] local checksum [sum:%d, kvs:%d, size:%v]",
lonng marked this conversation as resolved.
Show resolved Hide resolved
t.tableName, localChecksum.Sum(), localChecksum.SumKVS(), localChecksum.SumSize())
if cp.Status < CheckpointStatusChecksummed {
if !rc.cfg.PostRestore.Checksum {
common.AppLogger.Infof("[%s] Skip checksum.", t.tableName)
rc.saveStatusCheckpoint(t.tableName, wholeTableEngineID, nil, CheckpointStatusChecksumSkipped)
} else {
err := t.compareChecksum(ctx, rc.tidbMgr.db, cp)
err := t.compareChecksum(ctx, rc.tidbMgr.db, localChecksum)
rc.saveStatusCheckpoint(t.tableName, wholeTableEngineID, err, CheckpointStatusChecksummed)
if err != nil {
common.AppLogger.Errorf("[%s] checksum failed: %v", t.tableName, err.Error())
Expand Down Expand Up @@ -1198,14 +1206,7 @@ func (tr *TableRestore) importKV(ctx context.Context, closedEngine *kv.ClosedEng
}

// do checksum for each table.
func (tr *TableRestore) compareChecksum(ctx context.Context, db *sql.DB, cp *TableCheckpoint) error {
var localChecksum verify.KVChecksum
for _, engine := range cp.Engines {
for _, chunk := range engine.Chunks {
localChecksum.Add(&chunk.Checksum)
}
}

func (tr *TableRestore) compareChecksum(ctx context.Context, db *sql.DB, localChecksum verify.KVChecksum) error {
start := time.Now()
remoteChecksum, err := DoChecksum(ctx, db, tr.tableName)
dur := time.Since(start)
Expand Down