Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

restore: add local checksum log #153

Merged
merged 2 commits into from
Mar 27, 2019
Merged

restore: add local checksum log #153

merged 2 commits into from
Mar 27, 2019

Conversation

lonng
Copy link
Contributor

@lonng lonng commented Mar 27, 2019

What problem does this PR solve?

Add local checksum information, which helps us to compare checksum manually when executing ADMIN CHECKSUM TABLE table_name timeout.

What is changed and how it works?

Add some logs.

Check List

Tests

  • Integration test

Side effects

N/A

Related changes

N/A

Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

lightning/restore/restore.go Outdated Show resolved Hide resolved
Co-Authored-By: lonng <chris@lonng.org>
@IANTHEREAL
Copy link
Collaborator

LGTM

@kennytm kennytm added status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) priority/unimportant type/enhancement Performance improvement or refactoring labels Mar 27, 2019
@kennytm
Copy link
Collaborator

kennytm commented Mar 27, 2019

/run-all-tests

@kennytm
Copy link
Collaborator

kennytm commented Mar 27, 2019

/run-all-tests tidb=pr/9880

@kennytm kennytm merged commit 80f7c41 into master Mar 27, 2019
@kennytm kennytm deleted the lonng/local-checksum-log branch March 27, 2019 08:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) type/enhancement Performance improvement or refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants