fix(stmt): min value of max stmt count size & blank detail page #982
Conversation
shhdgit
commented
Aug 13, 2021
•
shhdgit
commented
- Min of max stmt count size cannot be zero.
- Fix blank detail page bug caused by incorrect time range.
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
shhdgit
changed the title
shhdgit
changed the title
|
/cc @breeswish @baurine |
|
with more and more complex the cache keys seem really dirty. |
|
I have tried to separate the cache. The other way around in this God controller would be much dirtier and we need to consider refactoring it. The purpose of the current fix is to sync the data cache with the real time range. Because the list data is cached, and the real time range is recalculated every time the page is entered, it cannot be matched here. |
|
Thanks for the advice~~ We do need to refactor the large controller for stmt and slow query, which makes it difficult to understand the intent of the code changes. T T |
shhdgit
force-pushed
the
fix/stmt-config
branch
2 times, most recently
from
bc1b690 to
13b0719
Compare
shhdgit
force-pushed
the
fix/stmt-config
branch
from
13b0719 to
1d1a17d
Compare
|
When the list data outdated it looks like this:
|
shhdgit
force-pushed
the
fix/stmt-config
branch
from
00d53c8 to
cc7c515
Compare
|
That's true. I can open another pr to refactor the code. |
|
@shhdgit: GitHub didn't allow me to request PR reviews from the following users: unbyte. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Co-authored-by: Wenxuan <hi@breeswish.org>
typo
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: d8c2b9d
|
* Support non root user login (#985) Co-authored-by: Wenxuan <hi@breeswish.org> Co-authored-by: crazycs <chen.two.cs@gmail.com> * tweak(debugapi): pprof endpoint debug param (#1005) * Tweak: component invalid address check (#994) * tweak(client): add clients addr check & fix debugapi SSRF vulnerability * chore: update comments * fix: lints * fix: proxy url at tidb/client * feat(client): member cache * chore: rename * chore: remove unnecessary tidb proxy addr parse * server: add --log-dir to specify logstore dir (#873) * build(deps): bump tmpl from 1.0.4 to 1.0.5 in /ui (#1007) * build(deps): bump tmpl from 1.0.4 to 1.0.5 in /ui/tests (#1008) * support authorize non root user to sso login (#1003) * fix: debug api pprof timeout & refine api model (#964) * fix(stmt): min value of max stmt count size & blank detail page (#982) * Refine non root login (#1009) * make non-root-login default value false * add tooltip to ask for upgrade tidb to support login with non root * Update ui/dashboardApp/layout/translations/zh.yaml Co-authored-by: Wenxuan <hi@breeswish.org> * Update ui/dashboardApp/layout/translations/en.yaml Co-authored-by: Wenxuan <hi@breeswish.org> Co-authored-by: Wenxuan <hi@breeswish.org> * add doc link for insufficient privileges error (#1012) * update release-version Co-authored-by: Wenxuan <hi@breeswish.org> Co-authored-by: crazycs <chen.two.cs@gmail.com> Co-authored-by: Suhaha <jklopsdfw@gmail.com> Co-authored-by: 9547 <nivefive9547@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
