server: add --log-dir to specify logstore dir #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
breezewish
reviewed
Mar 10, 2021
added 2 commits
March 23, 2021 22:15
Signed-off-by: 9547 <nivefive9547@gmail.com>
9547
force-pushed
the
feature/specify-log-dir
branch
from
907d392 to
c1dbbed
Compare
|
@breeswish PTAL. |
breezewish
force-pushed
the
master
branch
2 times, most recently
from
b4a5d28 to
ab56290
Compare
breezewish
approved these changes
Sep 17, 2021
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: c1dbbed
|
baurine
pushed a commit
to baurine/tidb-dashboard
that referenced
this pull request
Sep 26, 2021
baurine
added a commit
that referenced
this pull request
Sep 26, 2021
* Support non root user login (#985) Co-authored-by: Wenxuan <hi@breeswish.org> Co-authored-by: crazycs <chen.two.cs@gmail.com> * tweak(debugapi): pprof endpoint debug param (#1005) * Tweak: component invalid address check (#994) * tweak(client): add clients addr check & fix debugapi SSRF vulnerability * chore: update comments * fix: lints * fix: proxy url at tidb/client * feat(client): member cache * chore: rename * chore: remove unnecessary tidb proxy addr parse * server: add --log-dir to specify logstore dir (#873) * build(deps): bump tmpl from 1.0.4 to 1.0.5 in /ui (#1007) * build(deps): bump tmpl from 1.0.4 to 1.0.5 in /ui/tests (#1008) * support authorize non root user to sso login (#1003) * fix: debug api pprof timeout & refine api model (#964) * fix(stmt): min value of max stmt count size & blank detail page (#982) * Refine non root login (#1009) * make non-root-login default value false * add tooltip to ask for upgrade tidb to support login with non root * Update ui/dashboardApp/layout/translations/zh.yaml Co-authored-by: Wenxuan <hi@breeswish.org> * Update ui/dashboardApp/layout/translations/en.yaml Co-authored-by: Wenxuan <hi@breeswish.org> Co-authored-by: Wenxuan <hi@breeswish.org> * add doc link for insufficient privileges error (#1012) * update release-version Co-authored-by: Wenxuan <hi@breeswish.org> Co-authored-by: crazycs <chen.two.cs@gmail.com> Co-authored-by: Suhaha <jklopsdfw@gmail.com> Co-authored-by: 9547 <nivefive9547@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default logstore path is under
ioutil.TempFile. In some cases, we need to store the searched logs in a specific place.