Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pump/storge: Measure time taken to write to disk, to rotate and fsync #794

Merged
merged 1 commit into from
Nov 11, 2019

Conversation

suzaku
Copy link
Contributor

@suzaku suzaku commented Nov 5, 2019

cherry-pick #773 to release-3.1


What problem does this PR solve?

We only measurer the time taken to write a batch of binlogs at the top level.
But we have no other measurementt to help us figure out which step is taking up most of the time.

What is changed and how it works?

Add 3 metrics:

  1. Time taken to write a buf
  2. Time taken to rotate
  3. Time taken to fsync

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to update the documentation
  • Need to update the tidb-ansible repository

@suzaku
Copy link
Contributor Author

suzaku commented Nov 5, 2019

/run-all-tests

@suzaku
Copy link
Contributor Author

suzaku commented Nov 5, 2019

/run-integration-tests

@july2993
Copy link
Contributor

july2993 commented Nov 5, 2019

@suzaku you should merge release-3.0 to address the ci, same as another pr.
fix by https://github.com/pingcap/tidb-binlog/pull/787/files#diff-9f5b9d4e03b955e4e502000abc6d7c3fR17 cause it create the db before restarting drainer

@suzaku
Copy link
Contributor Author

suzaku commented Nov 6, 2019

@suzaku you should merge release-3.0 to address the ci, same as another pr.
fix by https://github.com/pingcap/tidb-binlog/pull/787/files#diff-9f5b9d4e03b955e4e502000abc6d7c3fR17 cause it create the db before restarting drainer

Do you mean release-3.1, this is a PR for the release-3.1 branch.

@july2993
Copy link
Contributor

july2993 commented Nov 6, 2019

@suzaku you should merge release-3.0 to address the ci, same as another pr.
fix by https://github.com/pingcap/tidb-binlog/pull/787/files#diff-9f5b9d4e03b955e4e502000abc6d7c3fR17 cause it create the db before restarting drainer

Do you mean release-3.1, this is a PR for the release-3.1 branch.

yes

@suzaku
Copy link
Contributor Author

suzaku commented Nov 6, 2019

/run-all-tests

@july2993
Copy link
Contributor

july2993 commented Nov 6, 2019

LGMT

@july2993
Copy link
Contributor

@GregoryIan PTAL

Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one merged commit f4116ae into pingcap:release-3.1 Nov 11, 2019
@suzaku suzaku deleted the measure-3.1 branch November 19, 2019 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants