pump/storge: Measure time taken to write to disk, to rotate and fsync #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tetsts |
|
/run-all-tests |
|
Good Job! LGTM |
|
/run-cherry-picker |
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.0 failed |
|
cherry pick to release-3.1 failed |
|
/run-cherry-picker |
1 similar comment
|
/run-cherry-picker |
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.0 in PR #783 |
|
cherry pick to release-3.1 in PR #784 |
suzaku
added a commit
to suzaku/tidb-binlog
that referenced
this pull request
Nov 5, 2019
suzaku
added a commit
to suzaku/tidb-binlog
that referenced
this pull request
Nov 5, 2019
This was referenced Nov 5, 2019
suzaku
added a commit
to suzaku/tidb-binlog
that referenced
this pull request
Nov 6, 2019
suzaku
added a commit
to suzaku/tidb-binlog
that referenced
this pull request
Nov 6, 2019
zier-one
pushed a commit
that referenced
this pull request
Nov 11, 2019
zier-one
pushed a commit
that referenced
this pull request
Nov 11, 2019
|
/run-cherry-picker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
We only measurer the time taken to write a batch of binlogs at the top level.
But we have no other measurementt to help us figure out which step is taking up most of the time.
What is changed and how it works?
Add 3 metrics:
Check List
Tests
Code changes
Side effects
Related changes
tidb-ansiblerepository