Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drainer/: Fix when pk is handle and value overflow int64 #574

Merged
merged 1 commit into from
Apr 30, 2019
Merged

drainer/: Fix when pk is handle and value overflow int64 #574

merged 1 commit into from
Apr 30, 2019

Conversation

july2993
Copy link
Contributor

What problem does this PR solve?

cherry-pick #573

What is changed and how it works?

pick #573
also update tests as master branch

Check List

Tests

  • Unit test
  • Integration test
    Code changes

Side effects

Related changes

@july2993
Copy link
Contributor Author

/run-integration-tests tidb=release2.1 tikv=release2.1 pd=release2.1

@july2993
Copy link
Contributor Author

/run-integration-tests

@july2993
Copy link
Contributor Author

PTAL @suzaku @csuzhangxc ignore the check ci, it's only support to be work at master now

@suzaku
Copy link
Contributor

suzaku commented Apr 30, 2019

LGTM

csuzhangxc
csuzhangxc approved these changes Apr 30, 2019
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@july2993 july2993 merged commit fa444d5 into release-2.1 Apr 30, 2019
@july2993 july2993 deleted the hjh/pfix_pk_type branch April 30, 2019 08:55
@csuzhangxc csuzhangxc mentioned this pull request May 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
priority/important status/LGT2 status/PTAL type/cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@july2993 @suzaku @csuzhangxc