Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: save checkpoint with schemaVersion #1033

Merged
merged 11 commits into from
Jan 11, 2021
Merged

ddl: save checkpoint with schemaVersion #1033

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5de9742
ddl: save checkpoint with schemaVersion
3pointer Dec 30, 2020
cbffe98
fix build
3pointer Dec 31, 2020
8ad6cfd
fix
3pointer Jan 5, 2021
51ae981
Update drainer/syncer.go
3pointer Jan 8, 2021
2ba39fa
Merge branch 'fix_load_schema_version' of https://github.com/3pointer…
3pointer Jan 8, 2021
eb3ef2a
address comment
3pointer Jan 8, 2021
5c61dcb
address comment
3pointer Jan 8, 2021
34fbc7e
fix
3pointer Jan 8, 2021
04e144a
add retry for save checkpoint
3pointer Jan 11, 2021
ee82a67
change log.Fatal to log.Error when save checkpoint failed
3pointer Jan 11, 2021
7c16404
add Fatal back when save point failed
3pointer Jan 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@3pointer
3pointer committed Jan 5, 2021
commit 8ad6cfd45e704cfd18f24775b62bbaa2d043f128
2 changes: 1 addition & 1 deletion drainer/syncer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ func (s *Syncer) run() error {

s.enableSafeModeInitializationPhase()

err = s.schema.handlePreviousDDLJobIfNeed(s.cp.SchemaVersion())
err = s.schema.handlePreviousDDLJobIfNeed(s.cp.SchemaVersion()+1)
if err != nil {
err = errors.Annotate(err, "handlePreviousDDLJobIfNeed failed")
return err
Expand Down