ddl: save checkpoint with schemaVersion #1033
Conversation
3pointer
changed the title
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
3pointer
changed the title
drainer/checkpoint/file.go
Outdated
| @@ -92,6 +93,7 @@ func (sp *FileCheckPoint) Save(ts, secondaryTS int64, consistent bool) error { | |||
|
|
|||
| sp.CommitTS = ts | |||
| sp.ConsistentSaved = consistent | |||
| sp.Version = version | |||
There was a problem hiding this comment.
Should we prevent the version being reduced here?
There was a problem hiding this comment.
A recently test case shows that drainer writes the old schema version again after manually adjusting the schema version to the correct value.
There was a problem hiding this comment.
The test case with amend transaction enabled.
| dml | ddl | schema version |
|---|---|---|
| begin | 1 | |
| insert... | ||
| ddls | from 1 to 10 | |
| commit | 10 |
The ddls are executed before transaction committed and push the schema version to 10 in checkpoint. When the drainer is executing the dml transaction, the schema version of it is still 1, and will checkpoint with schema version 1 into checkpoint.
drainer/syncer.go
Outdated
| eventCounter.WithLabelValues("savepoint").Add(1) | ||
| } | ||
|
|
||
| log.Info("handleSuccess quit") | ||
| } | ||
|
|
||
| func (s *Syncer) savePoint(ts, secondaryTS int64) { | ||
| func (s *Syncer) savePoint(ts, secondaryTS, version int64) { | ||
| if ts < s.cp.TS() { | ||
| log.Error("save ts is less than checkpoint ts %d", zap.Int64("save ts", ts), zap.Int64("checkpoint ts", s.cp.TS())) | ||
| } | ||
|
|
||
| log.Info("write save point", zap.Int64("ts", ts)) |
There was a problem hiding this comment.
May also log version in this function.
Co-authored-by: you06 <you1474600@gmail.com>
…/tidb-binlog into fix_load_schema_version
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
What problem does this PR solve?
Fix #1032
What is changed and how it works?
save schemaVersion to checkpoint.
with amend txn enabled.
prewrite.SchemeVersioncould out of date.so when drainer restart, we need to compare
checkpoint'SchemaVersionandprewrite.SchemaVersion.Check List
Tests
Related changes
Release note