support watch resource group #1035
Conversation
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: HuSharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
|
I think changes that break compatibility had better be merged together with dependent PRs. Otherwise it may block other changes |
Sry...My fault, should have made a draft label... |
This reverts commit de69cb9.
| int64 revision = 2; | ||
| } | ||
|
|
||
| enum ItemKind { |
There was a problem hiding this comment.
How about calling it EventType or something else which can represent that it is an action?
There was a problem hiding this comment.
You are right! from that way we can sync with Etcd
| } | ||
|
|
||
| message StoreGlobalConfigRequest { | ||
| repeated GlobalConfigItem changes = 1; | ||
| string config_path = 1; | ||
| repeated GlobalConfigItem changes = 2; |
There was a problem hiding this comment.
breaking change, shouldn't change the field number
There was a problem hiding this comment.
This interface was previously used by TopSQL as a configuration center control switch, but then chose another way.
tikv/pd/tidb are not use it.
tikv/pd#4308
Signed-off-by: husharp jinhao.hu@pingcap.com