Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade kvproto to the latest master #5861

Merged
merged 2 commits into from
Jan 16, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jan 13, 2023

Signed-off-by: Ryan Leung rleungx@gmail.com

What problem does this PR solve?

Issue Number: Ref #4399.

What is changed and how does it work?

Because pingcap/kvproto#1024 is merged, when we upgrade kvproto, it will have some dependency problems. This PR is used to replace the right version of gRPC dependency. Besides, pingcap/kvproto#1035 will introduce some compatibility problems, which this PR will delete the original implementation and tests, which can be added back once #5830 is merged.

Check List

Tests

  • Unit test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 13, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Jan 13, 2023
@rleungx rleungx requested review from CabinfeverB and JmPotato and removed request for disksing January 13, 2023 06:49
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Base: 75.46% // Head: 75.43% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (639c7dc) compared to base (0f75293).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 639c7dc differs from pull request most recent head 95ae9a5. Consider uploading reports for the commit 95ae9a5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5861      +/-   ##
==========================================
- Coverage   75.46%   75.43%   -0.03%     
==========================================
  Files         337      337              
  Lines       34146    34122      -24     
==========================================
- Hits        25768    25740      -28     
- Misses       6142     6162      +20     
+ Partials     2236     2220      -16     
Flag Coverage Δ
unittests 75.43% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/client.go 68.48% <ø> (+0.98%) ⬆️
server/grpc_service.go 47.23% <0.00%> (-2.16%) ⬇️
pkg/dashboard/keyvisual/input/core.go 0.00% <0.00%> (-33.34%) ⬇️
pkg/utils/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
server/schedulers/random_merge.go 62.50% <0.00%> (-3.13%) ⬇️
server/schedulers/shuffle_hot_region.go 55.12% <0.00%> (-2.57%) ⬇️
server/tso/tso.go 67.97% <0.00%> (-2.25%) ⬇️
tools/pd-ctl/pdctl/command/operator.go 66.66% <0.00%> (-1.15%) ⬇️
server/region_syncer/client.go 85.82% <0.00%> (-0.75%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 13, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 13, 2023
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
Copy link
Member Author

rleungx commented Jan 13, 2023

After this PR is merged, it will have some compatibility issues if we upgrade pd client dependency in some repo, e.g., TiDB. /cc @HuSharp

@rleungx
Copy link
Member Author

rleungx commented Jan 16, 2023

/merge

@ti-chi-bot
Copy link
Member

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 15715e2

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. and removed do-not-merge/needs-linked-issue labels Jan 16, 2023
@ti-chi-bot
Copy link
Member

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit be017f9 into tikv:master Jan 16, 2023
@rleungx rleungx deleted the upgrade-kvproto branch January 16, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants