Skip to content

update configure-placement-rules.md #9305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2022
Merged

update configure-placement-rules.md #9305

merged 2 commits into from
Oct 11, 2022

Conversation

disksing
Copy link
Contributor

Signed-off-by: disksing i@disksing.com

What is changed, added or deleted? (Required)

  • fix wrong placement rule example

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

@disksing
update configure-placement-rules.md
58f981b 
Signed-off-by: disksing <i@disksing.com>
@disksing disksing requested a review from qiancai June 23, 2022 05:55
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 23, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 23, 2022
@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. type/bugfix This PR fixes a bug. ONCALL Relates to documentation oncall. and removed missing-translation-status This PR does not have translation status info. labels Jun 23, 2022
qiancai
qiancai reviewed Jun 24, 2022
View reviewed changes
@qiancai qiancai added needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. labels Jun 24, 2022
@disksing
address comment
edd3791 
Signed-off-by: disksing <i@disksing.com>
@disksing disksing requested a review from qiancai July 7, 2022 02:38
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 27, 2022
@shichun-0415 shichun-0415 added the status/PTAL This PR is ready for reviewing. label Aug 27, 2022
Oreoxmt
Oreoxmt approved these changes Sep 28, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 28, 2022
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Oct 11, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: edd3791

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 11, 2022
@Oreoxmt Oreoxmt removed the status/PTAL This PR is ready for reviewing. label Oct 11, 2022
@ti-chi-bot ti-chi-bot merged commit 6123040 into pingcap:master Oct 11, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 11, 2022
Merged
8 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10728.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 11, 2022
Merged
8 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10729.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 11, 2022
Merged
8 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10730.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 11, 2022
Merged
8 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10731.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10732.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 11, 2022
Merged
8 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10733.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 11, 2022
Merged
8 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10734.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 11, 2022
Merged
8 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10735.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 11, 2022
Merged
8 tasks
ti-chi-bot added a commit that referenced this pull request Oct 11, 2022
@ti-chi-bot
update configure-placement-rules.md (#9305) (#10729)
e3df324
ti-chi-bot added a commit that referenced this pull request Oct 11, 2022
@ti-chi-bot
update configure-placement-rules.md (#9305) (#10733)
50851ec
ti-chi-bot added a commit that referenced this pull request Oct 11, 2022
@ti-chi-bot
update configure-placement-rules.md (#9305) (#10732)
8838d5a
ti-chi-bot added a commit that referenced this pull request Oct 11, 2022
@ti-chi-bot
update configure-placement-rules.md (#9305) (#10730)
a7916ec
ti-chi-bot added a commit that referenced this pull request Oct 11, 2022
@ti-chi-bot
update configure-placement-rules.md (#9305) (#10735)
36705b8
ti-chi-bot added a commit that referenced this pull request Oct 11, 2022
@ti-chi-bot
update configure-placement-rules.md (#9305) (#10734)
94fe3d8
ti-chi-bot added a commit that referenced this pull request Oct 11, 2022
@ti-chi-bot
update configure-placement-rules.md (#9305) (#10728)
170b85d
ti-chi-bot added a commit that referenced this pull request Oct 11, 2022
@ti-chi-bot
update configure-placement-rules.md (#9305) (#10731)
7e2f4ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@qiancai qiancai Awaiting requested review from qiancai

+1 more reviewer

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. ONCALL Relates to documentation oncall. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@disksing @ti-chi-bot @Oreoxmt @qiancai @shichun-0415 @TomShawn