Skip to content

update configure-placement-rules.md (#9305) #10734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2022
Merged

update configure-placement-rules.md (#9305) #10734

merged 2 commits into from
Oct 11, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9305

Signed-off-by: disksing i@disksing.com

What is changed, added or deleted? (Required)

  • fix wrong placement rule example

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

@disksing @ti-chi-bot
update configure-placement-rules.md
b67ab61 
Signed-off-by: disksing <i@disksing.com>
@disksing @ti-chi-bot
address comment
35f809c 
Signed-off-by: disksing <i@disksing.com>
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 11, 2022
Merged
8 tasks
@ti-chi-bot ti-chi-bot added area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. ONCALL Relates to documentation oncall. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR. labels Oct 11, 2022
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Oct 11, 2022

/status LGT1
/merge

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 11, 2022
@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 35f809c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 11, 2022
@ti-chi-bot ti-chi-bot merged commit 94fe3d8 into pingcap:release-5.1 Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shichun-0415 shichun-0415 Awaiting requested review from shichun-0415

Assignees

@disksing disksing

Labels
area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. ONCALL Relates to documentation oncall. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @Oreoxmt @disksing