Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misinformation in geo-distributed-deployment-topology.md #5503

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Fix misinformation in geo-distributed-deployment-topology.md #5503

merged 1 commit into from
Apr 26, 2021

Conversation

Liuxiaozhen12
Copy link
Contributor

Fix misinformation in geo-distributed-deployment-topology

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Update geo-distributed-deployment-topology.md
e4ea56c 
Fix misinformation in geo-distributed-deployment-topology
@ti-chi-bot ti-chi-bot requested a review from TomShawn April 26, 2021 08:05
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 26, 2021
@Liuxiaozhen12
Copy link
Contributor Author

/translation from-docs-cn
/label needs-cherry-pick-5.0
/label needs-cherry-pick-master

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-5.0 needs-cherry-pick-master Should cherry pick this PR to master branch. and removed missing-translation-status This PR does not have translation status info. labels Apr 26, 2021
@TomShawn
Copy link
Contributor

/uncc @TomShawn
/cc @CharLotteiu

@ti-chi-bot ti-chi-bot requested review from CharLotteiu and removed request for TomShawn April 26, 2021 08:11
@Liuxiaozhen12
Copy link
Contributor Author

/retitle Fix misinformation in geo-distributed-deployment-topology.md

@ti-chi-bot ti-chi-bot changed the title Update geo-distributed-deployment-topology.md Fix misinformation in geo-distributed-deployment-topology.md Apr 26, 2021
TomShawn
TomShawn approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 26, 2021
@TomShawn
Copy link
Contributor

/uncc CharLotteiu
/label require-LGT1

@ti-chi-bot ti-chi-bot removed the request for review from CharLotteiu April 26, 2021 08:51
@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 26, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e4ea56c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 26, 2021
@ti-chi-bot ti-chi-bot merged commit 19fa5c6 into pingcap:master Apr 26, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 26, 2021
@Liuxiaozhen12 @ti-srebot
cherry pick pingcap#5503 to release-5.0
36f3daa 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5516

ti-chi-bot pushed a commit that referenced this pull request Apr 26, 2021
@ti-srebot
Fix misinformation in geo-distributed-deployment-topology.md (#5503) (#…
d8259dd 
…5516)
@Liuxiaozhen12
Copy link
Contributor Author

/remove-label needs-cherry-pick-master
/label needs-cherry-pick-4.0

@ti-chi-bot ti-chi-bot removed the needs-cherry-pick-master Should cherry pick this PR to master branch. label Apr 26, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 26, 2021
@Liuxiaozhen12 @ti-srebot
cherry pick pingcap#5503 to release-4.0
3b3049e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5517

ti-chi-bot pushed a commit that referenced this pull request Apr 26, 2021
@ti-srebot
Fix misinformation in geo-distributed-deployment-topology.md (#5503) (#…
bbd5e4e 
…5517)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Liuxiaozhen12 @TomShawn @ti-chi-bot @ti-srebot