Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misinformation in geo-distributed-deployment-topology.md #5651

Merged
merged 3 commits into from
Apr 25, 2021
Merged

Fix misinformation in geo-distributed-deployment-topology.md #5651

merged 3 commits into from
Apr 25, 2021

Conversation

King-Dylan
Copy link
Contributor

@King-Dylan King-Dylan commented Mar 3, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@TomShawn TomShawn changed the title Update geo-distributed-deployment-topology.md Fix misinformation in geo-distributed-deployment-topology.md Mar 3, 2021
@TomShawn TomShawn self-assigned this Mar 3, 2021
@TomShawn TomShawn added needs-cherry-pick-master Should cherry pick this PR to master branch. needs-cherry-pick-5.0 size/small Changes of a small size. translation/doing This PR’s assignee is translating this PR. labels Mar 3, 2021
TomShawn
TomShawn approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 3, 2021
@TomShawn TomShawn closed this Mar 3, 2021
@TomShawn TomShawn reopened this Mar 3, 2021
@TomShawn TomShawn closed this Mar 3, 2021
@TomShawn TomShawn reopened this Mar 3, 2021
@TomShawn
Copy link
Contributor

/rebase

@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/small Changes of a small size. labels Apr 25, 2021
@yikeke yikeke merged commit c17dbb7 into pingcap:release-4.0 Apr 25, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 25, 2021
@King-Dylan @ti-srebot
cherry pick pingcap#5651 to release-5.0
29fe5c3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 25, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #6143

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 25, 2021
@King-Dylan @ti-srebot
cherry pick pingcap#5651 to master
d366a30 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 25, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to master in PR #6144

ti-chi-bot pushed a commit that referenced this pull request Apr 25, 2021
@ti-srebot
Fix misinformation in geo-distributed-deployment-topology.md (#5651) (#…
b5c4e95 
…6143)
ti-chi-bot pushed a commit that referenced this pull request Apr 25, 2021
@ti-srebot
Fix misinformation in geo-distributed-deployment-topology.md (#5651) (#…
2e52bf9 
…6144)
@TomShawn
Copy link
Contributor

/unassign
/assign @Liuxiaozhen12

@ti-chi-bot ti-chi-bot assigned Liuxiaozhen12 and unassigned TomShawn Apr 26, 2021
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Apr 26, 2021
Merged
10 tasks
@Liuxiaozhen12
Copy link
Contributor

/remove-translation doing
/translation done

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 26, 2021
This was referenced Apr 26, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@yikeke yikeke yikeke left review comments

Assignees

@Liuxiaozhen12 Liuxiaozhen12

Labels
needs-cherry-pick-master Should cherry pick this PR to master branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@King-Dylan @TomShawn @ti-srebot @Liuxiaozhen12 @yikeke @ti-chi-bot