Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some Tiflash tune instructions.md #5499

Merged
merged 3 commits into from
Apr 29, 2021
Merged

Add some Tiflash tune instructions.md #5499

merged 3 commits into from
Apr 29, 2021

Conversation

Liuxiaozhen12
Copy link
Contributor

What is changed, added or deleted? (Required)

add some tiflash tune instructions

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Update tune-tiflash-performance.md
8eca631 
add some tiflash tune instructions
@ti-chi-bot ti-chi-bot requested a review from TomShawn April 26, 2021 07:16
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 26, 2021
@Liuxiaozhen12
Copy link
Contributor Author

/translation from-docs-cn
/label needs-cherry-pick-5.0

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-5.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 26, 2021
@TomShawn
Copy link
Contributor

/uncc @TomShawn
/cc @CharLotteiu

@ti-chi-bot ti-chi-bot requested review from CharLotteiu and removed request for TomShawn April 26, 2021 08:07
@Liuxiaozhen12
Copy link
Contributor Author

/retitle Add some Tiflash tune instructions.md

@ti-chi-bot ti-chi-bot changed the title Update tune-tiflash-performance.md Add some Tiflash tune instructions.md Apr 26, 2021
CharLotteiu
CharLotteiu reviewed Apr 27, 2021
View reviewed changes
Copy link
Contributor

@CharLotteiu CharLotteiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

tiflash/tune-tiflash-performance.md Outdated Show resolved Hide resolved
tiflash/tune-tiflash-performance.md Outdated Show resolved Hide resolved
@CharLotteiu
Copy link
Contributor

/cc @hanfei1991

@ti-chi-bot ti-chi-bot requested a review from hanfei1991 April 27, 2021 06:45
@hanfei1991
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

@hanfei1991: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Liuxiaozhen12 and others added 2 commits April 29, 2021 10:26
@Liuxiaozhen12 @CharLotteiu
Update tiflash/tune-tiflash-performance.md
e4457cb 
Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
@Liuxiaozhen12 @CharLotteiu
Update tiflash/tune-tiflash-performance.md
2215708 
Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
@CharLotteiu
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 29, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@TomShawn: /merge in this pull request requires 2 /lgtm.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CharLotteiu
  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 29, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2215708

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 29, 2021
@ti-chi-bot ti-chi-bot merged commit 0c931e7 into pingcap:master Apr 29, 2021
@TomShawn
Copy link
Contributor

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 29, 2021
@Liuxiaozhen12 @ti-srebot
cherry pick pingcap#5499 to release-5.0
13f5a2a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 29, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5543

ti-chi-bot pushed a commit that referenced this pull request Apr 29, 2021
@ti-srebot
Add some Tiflash tune instructions.md (#5499) (#5543)
21fdf8f
@Liuxiaozhen12 Liuxiaozhen12 deleted the add-some-tiflash-tune-instructions branch June 25, 2021 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharLotteiu CharLotteiu CharLotteiu left review comments

@hanfei1991 hanfei1991 Awaiting requested review from hanfei1991

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Liuxiaozhen12 @TomShawn @CharLotteiu @hanfei1991 @ti-chi-bot @ti-srebot