Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add some tiflash tune instructions #6041

Merged
merged 3 commits into from
Apr 16, 2021
Merged

add some tiflash tune instructions #6041

merged 3 commits into from
Apr 16, 2021

Conversation

hanfei1991
Copy link
Member

What is changed, added or deleted? (Required)

TiFlash 调优建议 section

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 15, 2021
@TomShawn
Copy link
Contributor

@hanfei1991 请 involve 技术 review。

@hanfei1991
Copy link
Member Author

@ilovesoup PTAL

@TomShawn
Copy link
Contributor

/cc @ilovesoup
/assign
/label needs-cherry-pick-5.0
/translation doing

@ti-chi-bot ti-chi-bot added translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-5.0 labels Apr 16, 2021
@ti-chi-bot
Copy link
Member

@TomShawn: GitHub didn't allow me to request PR reviews from the following users: ilovesoup.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @ilovesoup
/assign
/label needs-cherry-pick-5.0
/translation doing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Apr 16, 2021
ilovesoup
ilovesoup approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@ilovesoup ilovesoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Member

@ilovesoup: /lgtm is only allowed for the reviewers in list.

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn
TomShawn reviewed Apr 16, 2021
View reviewed changes
tiflash/tune-tiflash-performance.md Outdated Show resolved Hide resolved
tiflash/tune-tiflash-performance.md Outdated Show resolved Hide resolved
hanfei1991 and others added 2 commits April 16, 2021 13:33
@hanfei1991 @TomShawn
Update tiflash/tune-tiflash-performance.md
d89efe2 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@hanfei1991 @TomShawn
Update tiflash/tune-tiflash-performance.md
d7cf18c 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Contributor

/label require-LGT1
/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added require-LGT1 Indicates that the PR requires an LGTM. status/LGT1 Indicates that a PR has LGTM 1. labels Apr 16, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d7cf18c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2021
@ti-chi-bot ti-chi-bot merged commit 2ae0799 into pingcap:master Apr 16, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 16, 2021
@hanfei1991 @ti-srebot
cherry pick pingcap#6041 to release-5.0
a3c51ec 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 16, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #6048

ti-chi-bot pushed a commit that referenced this pull request Apr 16, 2021
@ti-srebot
add some tiflash tune instructions (#6041) (#6048)
90bc00a
@TomShawn
Copy link
Contributor

/unassign
/assign @Liuxiaozhen12

@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Apr 26, 2021
Merged
10 tasks
@Liuxiaozhen12
Copy link
Contributor

/remove-translation doing
/translation done

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 26, 2021
@ti-srebot ti-srebot mentioned this pull request Apr 29, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@ilovesoup ilovesoup ilovesoup approved these changes

Assignees

@Liuxiaozhen12 Liuxiaozhen12

Labels
require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hanfei1991 @TomShawn @ti-chi-bot @ti-srebot @Liuxiaozhen12 @ilovesoup