Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update use br command line tool #5478

Merged
merged 4 commits into from
Apr 26, 2021
Merged

Update use br command line tool #5478

merged 4 commits into from
Apr 26, 2021

Conversation

Liuxiaozhen12
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

add a description about br's s3 permission.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn April 25, 2021 09:38
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 25, 2021
@Liuxiaozhen12
Copy link
Contributor Author

/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels Apr 25, 2021
@Liuxiaozhen12
Copy link
Contributor Author

/assign

@Liuxiaozhen12
Copy link
Contributor Author

/remove translation doing
/translation done

@ti-chi-bot ti-chi-bot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Apr 25, 2021
@Liuxiaozhen12
Copy link
Contributor Author

/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0

@Liuxiaozhen12
Copy link
Contributor Author

/remove-label translation done

@ti-chi-bot
Copy link
Member

@Liuxiaozhen12: The label(s) translation-done cannot be applied. These labels are supported: Hacktoberfest, contribution, first-time-contributor, requires-followup, good-first-issue, hacktoberfest-accepted, help-wanted, needs-cherry-pick-2.1, needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, needs-cherry-pick-5.0, needs-cherry-pick-master, question, require-LGT1, require-LGT2, require-LGT3, special-week, v4.0, v5.0, for-future-release, requires-version-specific-changes, website.

In response to this:

/remove-label translation-done

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Liuxiaozhen12
Copy link
Contributor Author

/remove-translation done

@ti-chi-bot ti-chi-bot removed the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Apr 25, 2021
@ti-chi-bot
Copy link
Member

@Liuxiaozhen12: The label(s) translation-done cannot be applied. These labels are supported: Hacktoberfest, contribution, first-time-contributor, requires-followup, good-first-issue, hacktoberfest-accepted, help-wanted, needs-cherry-pick-2.1, needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, needs-cherry-pick-5.0, needs-cherry-pick-master, question, require-LGT1, require-LGT2, require-LGT3, special-week, v4.0, v5.0, for-future-release, requires-version-specific-changes, website.

In response to this:

/remove-label translation-done

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn
TomShawn reviewed Apr 25, 2021
View reviewed changes
br/use-br-command-line-tool.md Outdated Show resolved Hide resolved
br/use-br-command-line-tool.md Outdated Show resolved Hide resolved
@TomShawn
Copy link
Contributor

/unassign @Liuxiaozhen12
This is a translation-from PR, so it does not need an assignee.

@TomShawn
Copy link
Contributor

/status require-change

@ti-chi-bot ti-chi-bot added the status/require-change Needs the author to address comments. label Apr 26, 2021
Liuxiaozhen12 and others added 2 commits April 26, 2021 13:44
@Liuxiaozhen12 @TomShawn
Update br/use-br-command-line-tool.md
a6ed753 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@Liuxiaozhen12 @TomShawn
Update br/use-br-command-line-tool.md
740bb7c 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Contributor

/remove-status require-change
/lgtm
/label require-LGT1

@ti-chi-bot ti-chi-bot added require-LGT1 Indicates that the PR requires an LGTM. and removed status/require-change Needs the author to address comments. labels Apr 26, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 26, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 740bb7c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 26, 2021
@ti-chi-bot ti-chi-bot merged commit a7d338e into pingcap:master Apr 26, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 26, 2021
@Liuxiaozhen12 @ti-srebot
cherry pick pingcap#5478 to release-4.0
f3f016f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5496

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 26, 2021
@Liuxiaozhen12 @ti-srebot
cherry pick pingcap#5478 to release-5.0
e92d94c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5497

ti-chi-bot pushed a commit that referenced this pull request Apr 26, 2021
@ti-srebot
Update use br command line tool (#5478) (#5496)
bd4d184
ti-chi-bot pushed a commit that referenced this pull request Apr 26, 2021
@ti-srebot
Update use br command line tool (#5478) (#5497)
f47b531
@Liuxiaozhen12
Copy link
Contributor Author

/retitle br: add s3 permission description.md

1 similar comment
@Liuxiaozhen12
Copy link
Contributor Author

/retitle br: add s3 permission description.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Liuxiaozhen12 @ti-chi-bot @TomShawn @ti-srebot