Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: add s3 permission description #6016

Merged
merged 5 commits into from
Apr 25, 2021
Merged

br: add s3 permission description #6016

merged 5 commits into from
Apr 25, 2021

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented Apr 12, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

add a description about br's s3 permission.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 12, 2021
overvenus
overvenus reviewed Apr 12, 2021
View reviewed changes
br/use-br-command-line-tool.md Outdated
@@ -341,6 +341,8 @@ br restore full \

如果需要恢复的数据并不是存储在本地，而是在 Amazon 的 S3 后端，那么需要在 `storage` 子命令中指定 S3 的存储路径，并且赋予 BR 节点和 TiKV 节点访问 Amazon S3 的权限。

完成一次备份恢复需要的权限包括 `s3:ListBucket`, `s3:PutObject`，`s3:GetObject`。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update https://docs.pingcap.com/zh/tidb/stable/use-br-command-line-tool#%E5%A4%87%E4%BB%BD%E6%95%B0%E6%8D%AE%E5%88%B0-amazon-s3-%E5%90%8E%E7%AB%AF%E5%AD%98%E5%82%A8 too.

Also, could you add documentation of what permission TiKV needs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, PTAL again

@TomShawn
Copy link
Contributor

/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0
/translation doing
/assign
/label require-LGT1

@ti-chi-bot ti-chi-bot added translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-4.0 require-LGT1 Indicates that the PR requires an LGTM. and removed missing-translation-status This PR does not have translation status info. labels Apr 12, 2021
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 15, 2021
overvenus
overvenus reviewed Apr 15, 2021
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

br/use-br-command-line-tool.md Outdated Show resolved Hide resolved
br/use-br-command-line-tool.md Outdated Show resolved Hide resolved
3pointer and others added 2 commits April 16, 2021 11:16
@3pointer @overvenus
Update br/use-br-command-line-tool.md
f2e00b8 
Co-authored-by: Neil Shen <overvenus@gmail.com>
@3pointer @overvenus
Update br/use-br-command-line-tool.md
c975804 
Co-authored-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 16, 2021
@YuJuncen
Copy link
Contributor

/sig migrate

@ti-chi-bot ti-chi-bot added the area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. label Apr 19, 2021
@YuJuncen
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YuJuncen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 19, 2021
@TomShawn
Copy link
Contributor

/sig docs

@ti-chi-bot ti-chi-bot added the sig/docs Indicates that the Issue or PR belongs to the docs SIG. label Apr 25, 2021
3pointer and others added 2 commits April 25, 2021 16:02
@3pointer @TomShawn
Update br/use-br-command-line-tool.md
634fce0 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@3pointer @TomShawn
Update br/use-br-command-line-tool.md
6175349 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Contributor

/lgtm

@TomShawn
Copy link
Contributor

/unassign
/assign @Liuxiaozhen12

@ti-chi-bot ti-chi-bot assigned Liuxiaozhen12 and unassigned TomShawn Apr 25, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6175349

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 25, 2021
@ti-chi-bot ti-chi-bot merged commit 19c2c5c into pingcap:master Apr 25, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 25, 2021
@3pointer @ti-srebot
cherry pick pingcap#6016 to release-4.0
64a7548 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 25, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #6151

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 25, 2021
@3pointer @ti-srebot
cherry pick pingcap#6016 to release-5.0
6f2111e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 25, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #6152

ti-chi-bot pushed a commit that referenced this pull request Apr 25, 2021
@ti-srebot
br: add s3 permission description (#6016) (#6152)
52cbe10
ti-chi-bot pushed a commit that referenced this pull request Apr 25, 2021
@ti-srebot
br: add s3 permission description (#6016) (#6151)
5f7ed16
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Apr 25, 2021
Merged
11 tasks
@Liuxiaozhen12
Copy link
Contributor

/remove-translation doing
/translation done

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 25, 2021
This was referenced Apr 26, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@overvenus overvenus overvenus left review comments

Assignees

@Liuxiaozhen12 Liuxiaozhen12

Labels
area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. require-LGT1 Indicates that the PR requires an LGTM. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@3pointer @TomShawn @YuJuncen @ti-chi-bot @ti-srebot @Liuxiaozhen12 @overvenus