Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: add description to explain the non-index test result #5032

Merged
merged 2 commits into from
Mar 16, 2021
Merged

benchmark: add description to explain the non-index test result #5032

merged 2 commits into from
Mar 16, 2021

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Mar 12, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

  • benchmark: add description to explain the non-index test result
  • Fix a typo: Region Group --> Raft Group

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 12, 2021
@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. size/small Changes of a small size. status/PTAL This PR is ready for reviewing. needs-cherry-pick-4.0 and removed missing-translation-status This PR does not have translation status info. labels Mar 12, 2021
@ti-srebot
Copy link
Contributor

@CharLotteiu, @Joyinqin, PTAL.

CharLotteiu
CharLotteiu approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@CharLotteiu CharLotteiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

benchmark/v4.0-performance-benchmarking-with-tpch.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 15, 2021
Joyinqin
Joyinqin suggested changes Mar 15, 2021
View reviewed changes
benchmark/v4.0-performance-benchmarking-with-tpch.md Outdated
@@ -163,6 +163,10 @@ To avoid TiKV and TiFlash racing for disk and I/O resources, mount the two NVMe

## Test result

> **Note:**
>
> The tables on which SQL statements are executed in this test only has the primary key and does not have secondary index. Therefore, the test result below is not influenced by index.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this test, the tables on which SQL statements are executed only have the primary keys and do not have secondary indexes. Therefore, the test result below is not influenced by the index.

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Mar 15, 2021
Joyinqin
Joyinqin approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@Joyinqin Joyinqin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 15, 2021
@TomShawn @CharLotteiu
Update benchmark/v4.0-performance-benchmarking-with-tpch.md
89a1df9 
Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
@ti-chi-bot ti-chi-bot removed the size/small Changes of a small size. label Mar 15, 2021
@TomShawn
Copy link
Contributor Author

@CharLotteiu PTAL again, thanks!

@TomShawn
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@TomShawn: /merge in this pull request requires 2 /lgtm.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@CharLotteiu
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CharLotteiu
  • Joyinqin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 16, 2021
@TomShawn
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 89a1df9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 16, 2021
@ti-chi-bot ti-chi-bot merged commit 08edcd7 into pingcap:master Mar 16, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 16, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5032 to release-4.0
a459080 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 16, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5043

@TomShawn TomShawn deleted the multiple-PR-alignt branch March 16, 2021 08:31
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 16, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5032 to release-5.0
2f46391 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 16, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5044

ti-chi-bot pushed a commit that referenced this pull request Mar 16, 2021
@ti-srebot
benchmark: add description to explain the non-index test result (#5032)…
b564cfe 
… (#5043)
ti-chi-bot pushed a commit that referenced this pull request Mar 16, 2021
@ti-srebot
benchmark: add description to explain the non-index test result (#5032)…
4fa86d7 
… (#5044)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joyinqin Joyinqin Joyinqin approved these changes

@CharLotteiu CharLotteiu CharLotteiu approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TomShawn @ti-srebot @ti-chi-bot @CharLotteiu @Joyinqin