Skip to content

Fix a typo in geo-distributed-deployment-topology.md #5689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2021
Merged

Fix a typo in geo-distributed-deployment-topology.md #5689

merged 2 commits into from
Mar 10, 2021

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Mar 9, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

Fix a typo in geo-distributed-deployment-topology.md: Region Group --> Raft Group

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. status/PTAL This PR is ready for reviewing. needs-cherry-pick-4.0 labels Mar 9, 2021
@TomShawn TomShawn self-assigned this Mar 9, 2021
@TomShawn TomShawn requested review from King-Dylan and lilin90 March 9, 2021 07:54
@ti-srebot
Copy link
Contributor

@King-Dylan, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

@TomShawn
Copy link
Contributor Author

According to @superlzs0476, Raft Group is OK.

lilin90
lilin90 approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 10, 2021
@TomShawn TomShawn merged commit d2b5ebf into master Mar 10, 2021
@TomShawn TomShawn deleted the TomShawn-patch-3 branch March 10, 2021 10:10
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Mar 10, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5689 to release-4.0
3ed162d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 10, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5705

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Mar 10, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5689 to release-5.0
da2564c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 10, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5706

TomShawn added a commit that referenced this pull request Mar 10, 2021
@ti-srebot @TomShawn
cherry pick #5689 to release-5.0 (#5706)
065d87a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn added a commit that referenced this pull request Mar 10, 2021
@ti-srebot @TomShawn
cherry pick #5689 to release-4.0 (#5705)
b1dc20f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn mentioned this pull request Mar 12, 2021
Merged
10 tasks
@TomShawn
Copy link
Contributor Author

/translation done
/remove-translation doing

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 12, 2021
This was referenced Mar 16, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

@King-Dylan King-Dylan Awaiting requested review from King-Dylan

@superlzs0476 superlzs0476 Awaiting requested review from superlzs0476

Assignees

@TomShawn TomShawn

Labels
status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TomShawn @ti-srebot @lilin90 @King-Dylan @ti-chi-bot