Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove system variable tidb_track_aggregate_memory_usage #5029

Merged
merged 1 commit into from
Mar 25, 2021
Merged

remove system variable tidb_track_aggregate_memory_usage #5029

merged 1 commit into from
Mar 25, 2021

Conversation

Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Mar 12, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

remove system variable tidb_track_aggregate_memory_usage.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 12, 2021
@Joyinqin
Copy link
Contributor Author

/label needs-cherry-pick-5.0

@Joyinqin
Copy link
Contributor Author

/label v5.0

@ti-chi-bot ti-chi-bot added the v5.0 This PR/issue applies to TiDB v5.0. label Mar 12, 2021
@Joyinqin
Copy link
Contributor Author

/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels Mar 12, 2021
@Joyinqin
Copy link
Contributor Author

/cc TomShawn

@ti-chi-bot ti-chi-bot requested a review from TomShawn March 12, 2021 07:50
TomShawn
TomShawn approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 12, 2021
@ti-chi-bot
Copy link
Member

@Joyinqin: GitHub didn't allow me to request PR reviews from the following users: qiancai.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc qiancai

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Joyinqin
Copy link
Contributor Author

/cc ran-huang

@ti-chi-bot ti-chi-bot requested a review from ran-huang March 12, 2021 08:08
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 15, 2021
@ti-chi-bot
Copy link
Member

@Joyinqin: /merge is only allowed for the committers in list.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor

TomShawn commented Mar 16, 2021 •
edited
Loading

@Joyinqin All v5.0 GA-related contents will be merged later as a part of our delivery plan.

@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d201424

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 25, 2021
@ti-chi-bot ti-chi-bot merged commit b33aa8e into pingcap:master Mar 25, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 25, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5029 to release-5.0
c4a6452 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 25, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5100

ti-chi-bot pushed a commit that referenced this pull request Mar 25, 2021
@ti-srebot
remove system variable tidb_track_aggregate_memory_usage (#5029) (#…
bbb212f 
…5100)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang approved these changes

@TomShawn TomShawn TomShawn approved these changes

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.0 This PR/issue applies to TiDB v5.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Joyinqin @ti-chi-bot @TomShawn @ti-srebot @ran-huang