Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove system variable tidb_track_aggregate_memory_usage #5704

Merged
merged 1 commit into from
Mar 19, 2021
Merged

remove system variable tidb_track_aggregate_memory_usage #5704

merged 1 commit into from
Mar 19, 2021

Conversation

wshwsh12
Copy link
Contributor

@wshwsh12 wshwsh12 commented Mar 10, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

remove system variable tidb_track_aggregate_memory_usage

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@TomShawn TomShawn requested a review from XuHuaiyu March 10, 2021 09:57
@qiancai
Copy link
Collaborator

qiancai commented Mar 11, 2021

/label needs-cherry-pick-5.0, v5.0

@ti-srebot ti-srebot added needs-cherry-pick-5.0 v5.0 This PR/issue applies to TiDB v5.0 labels Mar 11, 2021
@TomShawn TomShawn added size/small Changes of a small size. translation/doing This PR’s assignee is translating this PR. labels Mar 11, 2021
XuHuaiyu
XuHuaiyu reviewed Mar 11, 2021
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@qiancai: GitHub didn't allow me to request PR reviews from the following users: qiancai.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @qiancai

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai
Copy link
Collaborator

qiancai commented Mar 11, 2021

/lgtm

@ti-chi-bot
Copy link
Member

@qiancai: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@XuHuaiyu
Copy link
Contributor

/LGTM

@ti-chi-bot
Copy link
Member

@XuHuaiyu: /lgtm is only allowed for the reviewers in list.

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 12, 2021
@qiancai
Copy link
Collaborator

qiancai commented Mar 12, 2021

@Joyinqin, the content in this PR is ready for translation. PTAL, thanks!

@Joyinqin
Copy link
Contributor

/translation done

@ti-chi-bot ti-chi-bot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Mar 12, 2021
@Joyinqin Joyinqin mentioned this pull request Mar 12, 2021
Merged
11 tasks
@Joyinqin
Copy link
Contributor

/remove-translation doing

@ti-chi-bot ti-chi-bot removed the translation/doing This PR’s assignee is translating this PR. label Mar 12, 2021
@TomShawn
Copy link
Contributor

/label require-LGT1

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Mar 19, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6a6bb47

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 19, 2021
@ti-chi-bot ti-chi-bot merged commit c2a70d1 into pingcap:master Mar 19, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Mar 19, 2021
@wshwsh12 @ti-srebot
cherry pick pingcap#5704 to release-5.0
62d9e38 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 19, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5779

ti-chi-bot pushed a commit that referenced this pull request Mar 24, 2021
@ti-srebot
remove system variable tidb_track_aggregate_memory_usage (#5704) (#…
e8d7f9b 
…5779)
@ti-srebot ti-srebot mentioned this pull request Mar 25, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

Assignees

@Joyinqin Joyinqin

Labels
require-LGT1 Indicates that the PR requires an LGTM. size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.0 This PR/issue applies to TiDB v5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@wshwsh12 @qiancai @ti-chi-bot @XuHuaiyu @TomShawn @Joyinqin @ti-srebot