Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiflash does not support address 0.0.0.0 (#4705) #4714

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jan 25, 2021

cherry-pick #4705 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In docs repo:
git pr https://github.com/pingcap/docs/pull/4714

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/docs.git pr/4714:release-5.0-6c986fec80e1

First-time contributors' checklist

What is changed, added or deleted? (Required)

tiflash does not support address 0.0.0.0

[2021/01/04 14:30:48.404 +08:00] [FATAL] [setup.rs:254] ["invalid configuration: [src/server/config.rs:204]: invalid advertise-addr: \"0.0.0.0:20170\""]

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added size/small Changes of a small size. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. labels Jan 25, 2021
@ti-srebot ti-srebot requested a review from TomShawn January 25, 2021 10:54
@ti-srebot
Copy link
Contributor Author

@Joyinqin you're already a collaborator in bot's repo.

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 25, 2021
@TomShawn TomShawn merged commit ba05afb into pingcap:release-5.0 Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants