Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiflash does not support address 0.0.0.0 #4705

Merged
merged 3 commits into from
Jan 25, 2021

Conversation

Joyinqin
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

tiflash does not support address 0.0.0.0

[2021/01/04 14:30:48.404 +08:00] [FATAL] [setup.rs:254] ["invalid configuration: [src/server/config.rs:204]: invalid advertise-addr: \"0.0.0.0:20170\""]

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Joyinqin
Copy link
Contributor Author

/label needs-cherry-pick-3.1, needs-cherry-pick-4.0, needs-cherry-pick-5.0, size/small, translation/from-docs-cn

@ti-srebot ti-srebot added needs-cherry-pick-3.1 size/small Changes of a small size. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jan 25, 2021
quick-start-with-tidb.md Outdated Show resolved Hide resolved
Joyinqin and others added 2 commits January 25, 2021 15:47
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 25, 2021
@TomShawn TomShawn merged commit 6c986fe into pingcap:master Jan 25, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jan 25, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #4712

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jan 25, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4713

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jan 25, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #4714

TomShawn pushed a commit that referenced this pull request Jan 25, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
TomShawn pushed a commit that referenced this pull request Jan 25, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants