Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

pingcap / docs Public

Notifications You must be signed in to change notification settings
Fork 690
Star 602

Code
Issues 129
Pull requests 82
Actions
Projects 1
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change attribute value #4544

Merged

TomShawn merged 8 commits into pingcap:master from Joyinqin:change-attribute-value

Jan 4, 2021

Merged

Change attribute value #4544

TomShawn merged 8 commits into pingcap:master from Joyinqin:change-attribute-value

Jan 4, 2021

Conversation 13 Commits 8 Checks 0 Files changed

Conversation

Copy link

Contributor

Joyinqin commented Dec 30, 2020 •

edited by TomShawn

Loading

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

float change to int

Which TiDB version(s) do your changes apply to? (Required)

master (the latest development version)
v5.0 (TiDB 5.0 versions)
v4.0 (TiDB 4.0 versions)
v3.1 (TiDB 3.1 versions)
v3.0 (TiDB 3.0 versions)
v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

This PR is translated from: Change attribute value docs-cn#5177 Added capacity-mb and admission-max-result-mb parameter value types docs-cn#5182
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

Sorry, something went wrong.

All reactions


          Update tidb-configuration-file.md

60e27f2

Joyinqin marked this pull request as draft

December 30, 2020 09:52

Joyinqin and others added 3 commits

December 30, 2020 19:10


          Merge branch 'master' into change-attribute-value

f84ef2f


          Merge remote-tracking branch 'upstream/master' into change-attribute-…

59bfb37

…value


          Merge remote-tracking branch 'upstream/master' into change-attribute-…

6c923a8

…value

Copy link

Contributor Author

Joyinqin commented Jan 4, 2021

/label needs-cherry-pick-5.0, translation/from-docs-cn,needs-cherry-pick-4.0, size/small, size/small

All reactions

Sorry, something went wrong.

ti-srebot added needs-cherry-pick-4.0 size/small

Changes of a small size.

translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels

Copy link

Contributor Author

Joyinqin commented Jan 4, 2021

/cc TomShawn, glkappe

All reactions

Sorry, something went wrong.

Joyinqin marked this pull request as ready for review

January 4, 2021 03:16

ti-srebot requested review from glkappe and TomShawn

January 4, 2021 03:16

Copy link

Contributor Author

Joyinqin commented Jan 4, 2021

/label type/bug-fix

All reactions

Sorry, something went wrong.

ti-srebot added the type/bugfix This PR fixes a bug. label


          Merge branch 'master' into change-attribute-value

182a586

TomShawn reviewed

View reviewed changes

tidb-configuration-file.md Outdated Show resolved Hide resolved


          Update tidb-configuration-file.md

13a14fe

TomShawn approved these changes

View reviewed changes

Copy link

Contributor

TomShawn left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

All reactions

ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label

Copy link

glkappe commented Jan 4, 2021

fix https://github.com/pingcap/docs-cn/pull/5177/files

All reactions

Sorry, something went wrong.

TomShawn reviewed

View reviewed changes

tidb-configuration-file.md Outdated Show resolved Hide resolved

TomShawn reviewed

View reviewed changes

tidb-configuration-file.md Outdated Show resolved Hide resolved

TomShawn reviewed

View reviewed changes

tidb-configuration-file.md Show resolved Hide resolved

TomShawn reviewed

View reviewed changes

tidb-configuration-file.md Show resolved Hide resolved


          Apply suggestions from code review

963749c

TomShawn approved these changes

View reviewed changes

Copy link

Contributor

TomShawn left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

All reactions


          Merge branch 'master' into change-attribute-value

c68da00

TomShawn merged commit 7fb1cb4 into pingcap:master

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request


          cherry pick pingcap#4544 to release-4.0

24704cf

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request

Change attribute value (#4544) #4572

Merged

11 tasks

Copy link

Contributor

ti-srebot commented Jan 4, 2021

cherry pick to release-4.0 in PR #4572

All reactions

Sorry, something went wrong.

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request


          cherry pick pingcap#4544 to release-5.0

f2c42ef

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request

Change attribute value (#4544) #4573

Merged

11 tasks

Copy link

Contributor

ti-srebot commented Jan 4, 2021

cherry pick to release-5.0 in PR #4573

All reactions

Sorry, something went wrong.

TomShawn pushed a commit that referenced this pull request


          cherry pick #4544 to release-4.0 (#4572)

921e12e

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>

TomShawn pushed a commit that referenced this pull request


          cherry pick #4544 to release-5.0 (#4573)

c8d622d

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>

Joyinqin deleted the change-attribute-value branch

January 4, 2021 08:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

TomShawn TomShawn approved these changes

glkappe Awaiting requested review from glkappe

Assignees

No one assigned

Labels

Changes of a small size.

Indicates that a PR has LGTM 1.

translation/from-docs-cn

This PR is translated from a PR in pingcap/docs-cn.

This PR fixes a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.