Skip to content

Added capacity-mb and admission-max-result-mb parameter value types #5182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 4, 2021
Merged

Added capacity-mb and admission-max-result-mb parameter value types #5182

merged 2 commits into from
Jan 4, 2021

Conversation

glkappe
Copy link
Contributor

@glkappe glkappe commented Dec 28, 2020 •
edited
Loading

Sorry, this pr is to fix the following pr and add the parameter value type
https://github.com/pingcap/docs-cn/pull/5177/files

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@TomShawn
Copy link
Contributor

@glkappe Please involve a technical review first

@TomShawn TomShawn added needs-cherry-pick-4.0 size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. labels Dec 28, 2020
@TomShawn TomShawn requested a review from breezewish January 4, 2021 07:12
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 4, 2021
TomShawn
TomShawn approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jan 4, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 4, 2021
@TomShawn TomShawn merged commit 002f542 into pingcap:master Jan 4, 2021
@TomShawn TomShawn mentioned this pull request Jan 4, 2021
Merged
11 tasks
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jan 4, 2021
@glkappe @ti-srebot
cherry pick pingcap#5182 to release-4.0
c35221a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 4, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5241

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jan 4, 2021
@glkappe @ti-srebot
cherry pick pingcap#5182 to release-5.0
e8212c2 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 4, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5242

TomShawn pushed a commit that referenced this pull request Jan 4, 2021
@ti-srebot @glkappe
cherry pick #5182 to release-4.0 (#5241)
b465cf7 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: glkappe <qihang.li@pingcap.com>
TomShawn pushed a commit that referenced this pull request Jan 4, 2021
@ti-srebot @glkappe
cherry pick #5182 to release-5.0 (#5242)
731e72a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: glkappe <qihang.li@pingcap.com>
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jan 4, 2021
This was referenced Jan 4, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breezewish breezewish breezewish approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Joyinqin Joyinqin

Labels
size/small Changes of a small size. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@glkappe @TomShawn @ti-srebot @breezewish @Joyinqin