Skip to content

maintenance: update dynamic configuration #3529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 12, 2020
Merged

maintenance: update dynamic configuration #3529

merged 5 commits into from
Aug 12, 2020

Conversation

ran-huang
Copy link
Contributor

@ran-huang ran-huang commented Aug 3, 2020 •
edited
Loading

Signed-off-by: Ran huangran@pingcap.com

What is changed, added or deleted? (Required)

Align dynamic configuration with the Chinese version.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@ran-huang
update dynamic configuration
1d8b4c6 
Signed-off-by: Ran <huangran@pingcap.com>
@ran-huang
update dynamic config
088a3f3 
Signed-off-by: Ran <huangran@pingcap.com>
@ran-huang ran-huang marked this pull request as ready for review August 4, 2020 04:17
@ran-huang ran-huang added needs-cherry-pick-4.0 size/large Changes of a large size. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Aug 4, 2020
@ran-huang ran-huang requested review from TomShawn and rleungx August 4, 2020 04:19
@ti-srebot
Copy link
Contributor

@rleungx, @TomShawn, PTAL.

1 similar comment
@ti-srebot
Copy link
Contributor

@rleungx, @TomShawn, PTAL.

TomShawn
TomShawn reviewed Aug 10, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor edits

@ran-huang @TomShawn
Apply suggestions from code review
098212b 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ti-srebot
Copy link
Contributor

@TomShawn, @rleungx, PTAL.

rleungx
rleungx approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@rleungx,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@ran-huang
Copy link
Contributor Author

@TomShawn PTAL again. Thanks~

TomShawn
TomShawn reviewed Aug 12, 2020
View reviewed changes
TomShawn
TomShawn approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 12, 2020
@TomShawn TomShawn added require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. labels Aug 12, 2020
@TomShawn TomShawn merged commit 6e78dd5 into pingcap:master Aug 12, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Aug 12, 2020
@ran-huang @ti-srebot
cherry pick pingcap#3529 to release-4.0
5410904 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 12, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3633

ti-srebot added a commit that referenced this pull request Aug 12, 2020
@ti-srebot
maintenance: update dynamic configuration (#3529) (#3633)
1a559c9 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Signed-off-by: Ran <huangran@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/large Changes of a large size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ran-huang @ti-srebot @rleungx @TomShawn