Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add doc for dynamic config #2617

Merged
merged 9 commits into from
May 27, 2020
Merged

add doc for dynamic config #2617

merged 9 commits into from
May 27, 2020

Conversation

ran-huang
Copy link
Contributor

What is changed, added or deleted? (Required)

Add a doc for dynamic config.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@ran-huang ran-huang added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v4.0 This PR/issue applies to TiDB v4.0. needs-cherry-pick-4.0 labels May 26, 2020
@ran-huang ran-huang requested review from rleungx and TomShawn May 26, 2020 03:01
ran-huang and others added 2 commits May 26, 2020 13:45
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM
@rleungx PTAL

Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ran-huang
Copy link
Contributor Author

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 27, 2020

/run-all-tests

@sre-bot sre-bot merged commit 180f7b0 into pingcap:master May 27, 2020
@ran-huang ran-huang deleted the dynamic-config branch May 27, 2020 05:36
@TomShawn
Copy link
Contributor

/run-cherry-picker

sre-bot pushed a commit to sre-bot/docs that referenced this pull request May 28, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request May 28, 2020
5 tasks
@sre-bot
Copy link
Contributor

sre-bot commented May 28, 2020

cherry pick to release-4.0 in PR #2621

yikeke pushed a commit that referenced this pull request May 28, 2020
* cherry pick #2617 to release-4.0

Signed-off-by: sre-bot <sre-bot@pingcap.com>

* Update dynamic-config.md

Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v4.0 This PR/issue applies to TiDB v4.0.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants